Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
- Coverage 98.93% 98.93% -0.01%
==========================================
Files 15 15
Lines 6560 6559 -1
==========================================
- Hits 6490 6489 -1
Misses 70 70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@waynexia do you think we can remove |
Maybe we should keep it for compatibility with prometheus 2.x. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5aa62345ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ex.func.variadic > 0 { | ||
| let expected_args_len_without_default = expected_args_len.saturating_sub(1); | ||
| let expected_max_args_len = | ||
| expected_args_len_without_default + ex.func.variadic as usize; | ||
| if expected_max_args_len < actual_args_len { |
There was a problem hiding this comment.
For functions with variadic > 0, this branch now enforces only the maximum argument count and no longer enforces the required minimum (arg_types.len() - 1). That makes invalid calls like round() (and similarly info() / other bounded-variadic functions) pass semantic validation with zero arguments, which diverges from PromQL function signatures and allows malformed queries to parse successfully.
Useful? React with 👍 / 👎.
2 participants
add a python script to sync function with upstream.