Help button#8
Open
VitaJane wants to merge 3 commits into
Open
Conversation
Owner
|
Thanks again for your pull requests! As far as this one goes, there is definitely something to be said about making the current keyboard controls easier to understand at a glance. OTOH, I think this particular method, of popping up a whole new "window" with detailed text instructions goes quite a bit too far for inclusion in the basic script. For one thing, it's a whole new "window", and secondly, it's all in English, which would need to have options for translations to be swapped in. So while this is a neat idea, I would rather improve the way the current keyboard functions can be understood without adding extra text instructions. Cheers, though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the final change we did. It just creates a help button, showing what the different functions are.