Skip to content

Commit bbb3ac0

Browse files
author
Guillaume Lessard
committed
fix(deps): clear RUSTSEC-2026-0204, and stop test runs starving the runner pool
Two findings from the release dry run. RUSTSEC-2026-0204 blocked publish. `crossbeam-epoch 0.9.18` carries an invalid pointer dereference in the `fmt::Pointer` impl for `Atomic`/`Shared`. The dependency gate runs `strict: true` on a release, so this is a hard failure and the publish job would never have started - correctly. Updated to 0.9.20, the advisory's stated fix. cargo test --features full: 323 passed, 0 failed. Two advisories remain as warnings rather than errors and do not block: RUSTSEC-2024-0388 (`derivative` unmaintained) and RUSTSEC-2026-0190. tests.yml had no concurrency group. Every push spawned a fresh five-version matrix and superseded runs kept going, so four pushes in quick succession put ~20 test jobs in the pool at once and starved the release wheels of runners - a perfectly healthy release run sat at "queued" and a test run looked hung at 7% when it was simply waiting. One in-flight run per ref now, cancelling the rest. Deliberately not applied to release-build.yml: cancelling a half-finished release is worse than paying for it to complete.
1 parent 83c6e2f commit bbb3ac0

2 files changed

Lines changed: 13 additions & 2 deletions

File tree

.github/workflows/tests.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,17 @@ on:
77
branches: [main]
88
workflow_dispatch:
99

10+
# One in-flight test run per branch or PR. Without this, every push spawns a
11+
# fresh 5-version matrix and the superseded runs keep going: four pushes in
12+
# quick succession put ~20 test jobs in the pool at once, which starved the
13+
# release-build wheels of runners and made a healthy run look hung at 7%.
14+
#
15+
# Deliberately NOT applied to release-build.yml: cancelling a half-finished
16+
# release is worse than paying for it to complete.
17+
concurrency:
18+
group: tests-${{ github.workflow }}-${{ github.ref }}
19+
cancel-in-progress: true
20+
1021
jobs:
1122
rust:
1223
name: Rust tests

Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)