Merge pull request #16 from Guiziweb/feat/graceful-no-platform-fallback

feat(resolver): tolerate missing AI platform at install time with clear runtime error

Author: camilleislasse

composer.json

@@ -18,7 +18,7 @@
         "api-platform/symfony": "^4.3",
         "league/commonmark": "^2.8",
         "sylius/sylius": "^2.0",
-        "symfony/ai-platform": "dev-main as 0.8.x-dev",
+        "symfony/ai-platform": "^0.8",
         "symfony/framework-bundle": "^7.3",
         "symfony/rate-limiter": "^7.3",
         "twig/markdown-extra": "^3.24",
@@ -39,8 +39,9 @@
         "friends-of-behat/symfony-extension": "^2.6",
         "friends-of-behat/variadic-extension": "^1.6",
         "nyholm/psr7": "^1.8",
-        "symfony/ai-bundle": "dev-main as 0.8.x-dev",
-        "symfony/ai-open-ai-platform": "dev-main as 0.8.x-dev",
+        "symfony/ai-agent": "^0.8",
+        "symfony/ai-bundle": "^0.8",
+        "symfony/ai-open-ai-platform": "^0.8",
         "phpstan/phpstan": "^1.12",
         "phpstan/phpstan-doctrine": "^1.3",
         "phpstan/phpstan-webmozart-assert": "^1.2",
@@ -60,6 +61,7 @@
         "symfony/webpack-encore-bundle": "^2.2"
     },
     "suggest": {
+        "symfony/ai-bundle": "Required to enable AI features (declares Platform services from ai.yaml config)",
         "symfony/ai-open-ai-platform": "To use OpenAI as AI provider",
         "symfony/ai-anthropic-platform": "To use Anthropic Claude as AI provider",
         "symfony/ai-mistral-platform": "To use Mistral as AI provider"

config/services.yaml

@@ -14,6 +14,7 @@ services:
 
     Guiziweb\SyliusGridAssistantPlugin\Resolver\GridQueryResolver:
         arguments:
+            $platform: '@?Symfony\AI\Platform\PlatformInterface'
             $model: '%guiziweb.grid_assistant.model%'
 
     Guiziweb\SyliusGridAssistantPlugin\Twig\Extension\GridAssistantExtension:

src/Processor/GridQueryProcessor.php

@@ -4,6 +4,7 @@
 
 namespace Guiziweb\SyliusGridAssistantPlugin\Processor;
 
+use Guiziweb\SyliusGridAssistantPlugin\Resolver\GridQueryConfigurationException;
 use Guiziweb\SyliusGridAssistantPlugin\Resolver\GridQueryResolverException;
 use Guiziweb\SyliusGridAssistantPlugin\Resolver\GridQueryResolverInterface;
 use Guiziweb\SyliusGridAssistantPlugin\Schema\GridSchemaBuilderInterface;
@@ -54,6 +55,10 @@ public function process(string $query, string $gridCode, string $routeName, arra
 
         try {
             $resolved = $this->queryResolver->resolve($query, $gridCode);
+        } catch (GridQueryConfigurationException $e) {
+            $this->aiLogger->warning('[GridAssistant] Configuration error', ['error' => $e->getMessage()]);
+
+            throw new GridQueryProcessorException($e->getMessage(), 0, $e);
         } catch (GridQueryResolverException $e) {
             $this->aiLogger->warning('[GridAssistant] Resolver error', ['error' => $e->getMessage()]);
 

src/Resolver/GridQueryConfigurationException.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Guiziweb\SyliusGridAssistantPlugin\Resolver;
+
+final class GridQueryConfigurationException extends GridQueryResolverException
+{
+}

src/Resolver/GridQueryResolver.php

@@ -20,7 +20,7 @@
      * @param non-empty-string $model
      */
     public function __construct(
-        private PlatformInterface $platform,
+        private ?PlatformInterface $platform,
         private string $model,
         private GridSchemaBuilderInterface $schemaBuilder,
         private GridToolSchemaFactoryInterface $schemaFactory,
@@ -31,6 +31,10 @@ public function __construct(
 
     public function resolve(string $query, string $gridCode): ResolvedGridQuery
     {
+        if (null === $this->platform) {
+            throw new GridQueryConfigurationException('No AI platform configured. Run: composer require symfony/ai-bundle symfony/ai-openai-platform (or another bridge: symfony/ai-gemini-platform, symfony/ai-anthropic-platform, symfony/ai-mistral-platform), then configure ai.platform.<provider> in config/packages/ai.yaml.');
+        }
+
         $gridSchema = $this->schemaBuilder->buildSchema($gridCode);
         $parametersSchema = $this->schemaFactory->buildParameters($gridSchema);
 

src/Resolver/GridQueryResolverException.php

@@ -4,6 +4,6 @@
 
 namespace Guiziweb\SyliusGridAssistantPlugin\Resolver;
 
-final class GridQueryResolverException extends \RuntimeException
+class GridQueryResolverException extends \RuntimeException
 {
 }

tests/Unit/Resolver/GridQueryResolverTest.php

@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Guiziweb\SyliusGridAssistantPlugin\Tests\Unit\Resolver;
+
+use Guiziweb\SyliusGridAssistantPlugin\Resolver\GridQueryConfigurationException;
+use Guiziweb\SyliusGridAssistantPlugin\Resolver\GridQueryResolver;
+use Guiziweb\SyliusGridAssistantPlugin\Schema\GridSchemaBuilderInterface;
+use Guiziweb\SyliusGridAssistantPlugin\Toolbox\GridToolSchemaFactoryInterface;
+use PHPUnit\Framework\TestCase;
+use Psr\Clock\ClockInterface;
+use Psr\Log\LoggerInterface;
+
+final class GridQueryResolverTest extends TestCase
+{
+    public function testThrowsWhenNoPlatformIsConfigured(): void
+    {
+        $resolver = new GridQueryResolver(
+            null,
+            'gpt-4o',
+            $this->createMock(GridSchemaBuilderInterface::class),
+            $this->createMock(GridToolSchemaFactoryInterface::class),
+            $this->createMock(LoggerInterface::class),
+            $this->createMock(ClockInterface::class),
+        );
+
+        $this->expectException(GridQueryConfigurationException::class);
+        $this->expectExceptionMessageMatches('/No AI platform configured/');
+
+        $resolver->resolve('any query', 'sylius_admin_order');
+    }
+}