fix: preserve date picker state when switching back from unlimited#1904
Open
krisxcrash wants to merge 1 commit into
Open
fix: preserve date picker state when switching back from unlimited#1904krisxcrash wants to merge 1 commit into
krisxcrash wants to merge 1 commit into
Conversation
jeffredodd
approved these changes
May 21, 2026
jeffredodd
force-pushed
the
kw/timeoff-datepicker-after-unlimited-switch
branch
from
88d8bb7 to
94c3ead
Compare
When switching to unlimited and back to an accrual method, the custom reset date picker wasn't showing because the useEffect aggressively cleared resetDateType. Now the effect returns early for unlimited, preserving form state so the date picker restores on switch-back.
jeffredodd
force-pushed
the
kw/timeoff-datepicker-after-unlimited-switch
branch
from
94c3ead to
d05a532
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes bug: selecting unlimited then switching back to accrual hides the date picker and auto-fills Jan 1.
Test plan
PolicyConfigurationForm.test.tsxpasses (41/41)