fix: preserve carry-over balances when adding employees to policy#1907
Draft
krisxcrash wants to merge 1 commit into
Draft
fix: preserve carry-over balances when adding employees to policy#1907krisxcrash wants to merge 1 commit into
krisxcrash wants to merge 1 commit into
Conversation
Carry-over balances were computed from the currently visible/filtered page only. When employees paginated out of view, their balances were lost from the display. Now computes carry-over from all eligible employees so balances persist across search and pagination.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eligibleEmployees(the full unfiltered list) fromuseSelectEmployeesData.Fixes bug: time off starting balances are zeroed out when employees paginate out of view.
Test plan