chore: bump API version to v2025-11-15#38
Conversation
There was a problem hiding this comment.
🚀 2 New Security Fixes
You just committed 2 security fixes. 😎 Keep up the great work!
🎯 Take a look at what findings you fixed.
| Findings |
|---|
| CWE-338: Use of Cryptographically Weak Pseudo-Random Number Generator (PRNG) Original Rule ID: python_random_rule-random The product uses a Pseudo-Random Number Generator (PRNG) in a security context, but the PRNG's algorithm is not cryptographically strong. The application uses the random module to generate random values. The randommodule implements a Mersenne Twister PRNG which is not cryptographically secure and produces predictable values that can be exploited when used for tokens, session... |
| 📘 Learn More |
| CWE-338: Use of Cryptographically Weak Pseudo-Random Number Generator (PRNG) Original Rule ID: python_random_rule-random The product uses a Pseudo-Random Number Generator (PRNG) in a security context, but the PRNG's algorithm is not cryptographically strong. The application uses the random module to generate random values. The randommodule implements a Mersenne Twister PRNG which is not cryptographically secure and produces predictable values that can be exploited when used for tokens, session... |
| 📘 Learn More |
Scanner: boostsecurity - Semgrep
Fresh Eyes ReviewFound 4 issues in this PR. PR Description Issues
Download findings.json — drag the file into Claude or use Please 👍🏽 👎🏽 if you found this useful. Generated by Fresh Eyes Reviewer. Get help in #ai-code-reviews |
cdc408e to
1e34cfa
Compare
1e34cfa to
e2e2dfb
Compare
8b4b07a to
c79c5e6
Compare
e2e2dfb to
f000a45
Compare
f000a45 to
9426239
Compare
| actions: | ||
| - target: $.paths..schema..zip | ||
| update: | ||
| x-speakeasy-name-override: zip_code |
There was a problem hiding this comment.
🔴 Blocker | [fresh_eyes]: code-moves
Dropped overlay action: the original gusto_app_int/.speakeasy/speakeasy-modifications-overlay.yaml has TWO actions — $.paths..schema..zip AND $.components.schemas..properties.zip — but the new versioned copy only includes the first one. The original comments explain both are needed because address schemas referenced via $ref live under components.schemas and won't be caught by the $.paths.. rule alone. Without the second rule, the generated v2025-11-15 SDK will shadow Python's built-in zip() for those schemas (causing pylint W0622 failures).
Please 👍🏽 👎🏽 if you found this useful. Generated by Fresh Eyes Reviewer. Get help in #ai-code-reviews
| actions: | ||
| - target: $.paths..schema..zip | ||
| update: | ||
| x-speakeasy-name-override: zip_code |
There was a problem hiding this comment.
🔴 Blocker | [fresh_eyes]: code-moves
Dropped overlay action: the original gusto_embedded/.speakeasy/speakeasy-modifications-overlay.yaml has TWO actions — $.paths..schema..zip AND $.components.schemas..properties.zip — but the new versioned copy only includes the first one. Same issue as the app-int overlay: without the $.components.schemas..properties.zip target, zip properties on ref'd schemas won't be renamed to zip_code, shadowing Python's zip() builtin.
Please 👍🏽 👎🏽 if you found this useful. Generated by Fresh Eyes Reviewer. Get help in #ai-code-reviews
Summary
v2025-11-15Notes
Dependency: merge cleanup PR first (
chore: untrack .speakeasy/workflow.local.yaml). This PR has been rebased to assume the file is already gone.Merge order:
fix: harden codegen --new-version scaffold(script hardening)🤖 Generated with Claude Code