Add plMipmap::CompressJPEG().#306
Merged
Merged
Conversation
Hoikas
force-pushed
the
compress_jpeg
branch
from
f8413c1 to
36c04ec
Compare
zrax
reviewed
Sep 5, 2025
This adds an easy way to actually cause mipmaps with JPEG compression to actually its content. The implementation largely mirrors what Cyan does... If RLE can get the image down below 5KB, then don't compress. Otherwise, compress to jpeg. This is especially useful for Python apps where plJPEG::CompressImage() still doesn't have bindings.
Hoikas
force-pushed
the
compress_jpeg
branch
from
36c04ec to
fddf616
Compare
zrax
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an easy way to actually cause mipmaps with JPEG compression to actually its content. The implementation largely mirrors what Cyan does... If RLE can get the image down below 5KB, then don't compress. Otherwise, compress to jpeg.
This is especially useful for Python apps where plJPEG::CompressImage() still doesn't have bindings.