Fix plLocation encoding/decoding to match Plasma, and add tests.#311
Conversation
|
I looked into this a couple of years ago when implementing sequence number parsing in my NAGUS project, and also came to the conclusion that libHSPlasma was wrong :D If you want to compare notes (only for the MOUL format): these are my test cases (all taken from real ages currently in MOULa) and here's the text explanation of how I understand the encoding. At first glance, your code looks right to me. I'll try to take a detailed look at the logic soon. |
e34d801 to
b438f39
Compare
|
Good suggestion about using real PRP locations as test values... Despite modeling the tests after what Plasma's |
b438f39 to
3347d0a
Compare
3347d0a to
24a6b8e
Compare
dpogue
left a comment
There was a problem hiding this comment.
LGTM 👍
I guess Plasma itself is now the thing lacking unit tests for plLocation compatibility...
No description provided.