feat: add phase offset times to trial phases for convenience

Author: ericwang401

docs/usage.md

@@ -143,7 +143,7 @@ data/
 
 ### scan_log CSV
 
-One row per trial phase: `trial_n`, `phase`, `tr_n`, `phase_global_time`, `phase_trial_time`, `pulse_ct`.
+One row per trial phase: `trial_n`, `phase`, `tr_n`, `phase_onset_global_time`, `phase_offset_global_time`, `phase_onset_trial_time`, `phase_offset_trial_time`, `pulse_ct`. The `*_offset_*` (phase end) columns are tiled: a phase's end equals the next phase's onset, and the final phase of a trial ends at the trial end.
 
 ## Quitting Early
 

src/mid_det/recorder.py

@@ -128,6 +128,8 @@ class ScanPhase:
     phase_onset_global_time: float
     phase_onset_trial_time: float
     pulse_ct: int
+    phase_offset_global_time: float = 0.0
+    phase_offset_trial_time: float = 0.0
 
 
 BEHAVIORAL_COLUMNS: list[str] = [
@@ -148,7 +150,10 @@ class ScanPhase:
 ]
 
 SCAN_LOG_COLUMNS: list[str] = [
-    "trial_n", "phase", "tr_n", "phase_onset_global_time", "phase_onset_trial_time", "pulse_ct",
+    "trial_n", "phase", "tr_n",
+    "phase_onset_global_time", "phase_offset_global_time",
+    "phase_onset_trial_time", "phase_offset_trial_time",
+    "pulse_ct",
 ]
 
 

src/mid_det/trial.py

@@ -466,6 +466,17 @@ def _update_overlay(phase: str) -> None:
     time_trial_end = global_clock.getTime()
     time_sched_end = nominal_time
 
+    # Backfill each phase's end = onset of the next phase (tiled timeline);
+    # the final phase ends at the trial end.
+    for i, sp in enumerate(scan_phases):
+        end_global = (
+            scan_phases[i + 1].phase_onset_global_time
+            if i + 1 < len(scan_phases)
+            else time_trial_end
+        )
+        sp.phase_offset_global_time = end_global
+        sp.phase_offset_trial_time = end_global - time_onset
+
     record = TrialRecord(
         trial_n=trial_n,
         trial_type=trial_type,