Skip to content

Duplicate MQTT event handlers accumulate on integration reload, causing multiple service calls per button press #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Marco1971Repo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Duplicate MQTT event handlers accumulate on integration reload, causing multiple service calls per button press #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion custom_components/openhasp/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,13 @@ async def lwt_message_received(msg):
EVENT_HASP_PLATE_ONLINE,
{CONF_PLATE: self._entry.data[CONF_HWID]},
)
# Ensure any existing subscriptions are removed before
# re-registering, to avoid duplicate event handlers after
# a HA reload while the plate remains online (retained LWT
# message triggers this handler again on re-subscription).
for obj in self._objects:
await obj.disable_object()

if self._pages_jsonl:
await self.async_load_page(self._pages_jsonl)
else:
Expand Down Expand Up @@ -858,4 +865,4 @@ async def message_received(msg):
)

_LOGGER.debug("Subscribe to '%s' events on '%s'", self.obj_id, self.state_topic)
return await async_subscribe(self.hass, self.state_topic, message_received)
return await async_subscribe(self.hass, self.state_topic, message_received)
Loading