feat(sort): add props for custom sorting#329
Open
jxn-30 wants to merge 2 commits into
Open
Conversation
mrhammadasif
suggested changes
Oct 9, 2023
Contributor
mrhammadasif
left a comment
There was a problem hiding this comment.
Change of Coding Style is not recommended. Also, why do we have change in package-lock.json file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a feature proposal that adresses #177
The following new props have been added:
sort-functionmulti-sort-functionsort-functiontakes the following arguments:
it should return a number, if a nullish (
undefinedandnull) is returned, the default sort function will automatically be applied.multi-sort-functiontakes the following arguments:
it should return an Item[] (Array of Item-Objects). There is no "fallback to default if undefined returned" as for
sort-functionto allow more controll over the sorting.