Add example of running with example results#120
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the report under 'Hardware', we mention results are based on the
/example_resultsdir insidezarr_benchmarks+ people should follow instructions in the readme to reproduce the plots locally.Currently, we don't have an explicit example of using the
--example_resultsoption with the plotting scripts (you can only find it in the plotting help:python src/zarr_benchmarks/create_plots.py -h). As this is a bit hard to find, I added a brief note about how to reproduce the plots to theFinal resultssection.Also, there are a few small typo fixes I noticed while re-reading the report.