Final report#79
Conversation
K-Meech
left a comment
There was a problem hiding this comment.
Thanks @dstansby - looks good! I put some comments below.
Some more general points:
- We should give some details about the hardware the benchmarks were run on e.g. OS, RAM, number of cores, maybe type of storage (SSD type), as we are using the full time to read/write to disk?
- It would be good to mention that the points on the graphs are the mean values from 5 runs
- Exact numbers will have to be updated throughout once the benchmarks are run again with more iterations. I think a number of these plots aren't up to date with the latest example data?
ruaridhg
left a comment
There was a problem hiding this comment.
Looks good, just made a few minor suggestions.
Co-authored-by: Kimberly Meechan <24316371+K-Meech@users.noreply.github.com>
Co-authored-by: Kimberly Meechan <24316371+K-Meech@users.noreply.github.com>
0f7e1a6 to
b50fa85
Compare
Co-authored-by: ruaridhg <32329546+ruaridhg@users.noreply.github.com>
Co-authored-by: ruaridhg <32329546+ruaridhg@users.noreply.github.com>
|
(actually, not quite done, we should address #110 before considering this finsihed) |
ruaridhg
left a comment
There was a problem hiding this comment.
Just left a couple of comments for things that could/should be added.
|
@dstansby I'm part way through reviewing the final report - should be able to finish this tomorrow. I wasn't sure if the plots / text had been updated to match the latest results? E.g. running |
Co-authored-by: ruaridhg <32329546+ruaridhg@users.noreply.github.com>
update plots to match latest results
ruaridhg
left a comment
There was a problem hiding this comment.
Added more detailed alt text descriptions if necessary
Co-authored-by: Kimberly Meechan <24316371+K-Meech@users.noreply.github.com>
Co-authored-by: ruaridhg <32329546+ruaridhg@users.noreply.github.com>
Co-authored-by: Kimberly Meechan <24316371+K-Meech@users.noreply.github.com>
|
Thanks all for comments/contributions to this! |
This is a PR for the final report, in the form of the website. I intend for this to be pretty much the last thing we merge, but opening as a draft so everyone knows I'm working on this, and so I can use it to iterate on what graphs we want to put in here to tell the story.
Fixes #109
Fixes #108