Add MultiInstrumentCalibrator#950
Open
psavery wants to merge 2 commits into
Open
Conversation
This can calibrate multiple instruments simultaneously, while only allowing a small subset of instrument parameters to vary, or grain/material parameters to vary. Currently, the HEDM sample stage parameters (sample stage translation and chi) are the only instrument parameters which can vary between instruments. Otherwise, the detector tilts/translations and other parameters are shared and stay fixed between instruments. Even though only the sample stage parameters can currently be varied separately, it is relatively straightforward to extend this to other detector parameters too, as needed (we just need a unique prefix per detector). This is being used for a particular experiment done at CHESS, where a 3-grain ruby sample was scanned at 50 different sample stage locations. In this case, the detector parameters should all remain constant, and only the sample stage location vary between them. It is actually going to be very helpful for determining a good standard set of relative tilts/translations between subpanels for the Eiger. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Adds an optional `ome_step` to GrainCalibrator/sxcal_obj_func; when set, the omega residual is scaled by pixel_size/ome_step so a one-frame error counts like a one-pixel xy error. Defaults to None (unweighted), so existing behavior is unchanged. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
psavery
force-pushed
the
multi-instrument-calibrator
branch
from
7a0f1f9 to
83c223b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #950 +/- ##
==========================================
+ Coverage 73.36% 73.42% +0.05%
==========================================
Files 148 148
Lines 22805 22907 +102
==========================================
+ Hits 16732 16820 +88
- Misses 6073 6087 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This can calibrate multiple instruments simultaneously, while only allowing a small subset of instrument parameters to vary, or grain/material parameters to vary.
Currently, the HEDM sample stage parameters (sample stage translation and chi) are the only instrument parameters which can vary between instruments. Otherwise, the detector tilts/translations and other parameters are shared and stay fixed between instruments. Even though only the sample stage parameters can currently be varied separately, it is relatively straightforward to extend this to other detector parameters too, as needed (we just need a unique prefix per detector).
This is being used for a particular experiment done at CHESS, where a 3-grain ruby sample was scanned at 50 different sample stage locations. In this case, the detector parameters should all remain constant, and only the sample stage location vary between them. It is actually going to be very helpful for determining a good standard set of relative tilts/translations between subpanels for the Eiger.
Affected Workflows
Core (new feature only)