Add weekly report period to PeriodicReport#333
Merged
Conversation
Added a new weekly value to ReportPeriod and updated PeriodicReport to accommodate it. Updated AT_PeriodicReport to test for weekly reports and updated other failing tests to now account for the weekly ReportPeriod value.
Updated the weekly logic in PeriodicReport to now have weekly reports be flushed on an interval of day 7, day 14, day 21 etc regardless of what the sim start time was. With the old logic, we were just adding 7 days to whatever the sim start time was, which if the sim start time was 3.5 then the flush interval would be day 10, day 17, day 24, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new weekly value to ReportPeriod and updated PeriodicReport to accommodate it. Updated AT_PeriodicReport to test for weekly reports and updated other failing tests to now account for the weekly ReportPeriod value.