test(backend): guard workflow domain imports

Author: BugMaker-Boyan

packages/backend/app/test/test_architecture_boundaries.py

@@ -8,6 +8,14 @@
 
 APP_DIR = Path(__file__).resolve().parents[1]
 SERVICES_DIR = APP_DIR / "services"
+WORKFLOW_DIR = APP_DIR / "workflow"
+MOVED_WORKFLOW_SERVICE_MODULES = {
+    "app.services.workflow_agent_drafts",
+    "app.services.workflow_agent_response",
+    "app.services.workflow_agent_runs",
+    "app.services.workflow_repair_state",
+    "app.services.workflow_workspace_state",
+}
 
 
 def _imported_modules(path: Path) -> set[str]:
@@ -18,6 +26,7 @@ def _imported_modules(path: Path) -> set[str]:
             modules.update(alias.name for alias in node.names)
         elif isinstance(node, ast.ImportFrom) and node.module:
             modules.add(node.module)
+            modules.update(f"{node.module}.{alias.name}" for alias in node.names)
     return modules
 
 
@@ -31,3 +40,34 @@ def test_services_do_not_depend_on_tools_layer() -> None:
                 violations.append(f"{path.relative_to(APP_DIR)} imports {module}")
 
     assert violations == []
+
+
+def test_workflow_domain_does_not_depend_on_tools_layer() -> None:
+    violations: list[str] = []
+    for path in sorted(WORKFLOW_DIR.rglob("*.py")):
+        if path.name == "__init__.py":
+            continue
+        for module in sorted(_imported_modules(path)):
+            if module == "app.tools" or module.startswith("app.tools."):
+                violations.append(f"{path.relative_to(APP_DIR)} imports {module}")
+
+    assert violations == []
+
+
+def test_moved_workflow_services_use_domain_import_paths() -> None:
+    violations: list[str] = []
+    legacy_wrapper_paths = {
+        SERVICES_DIR / "workflow_agent_drafts.py",
+        SERVICES_DIR / "workflow_agent_response.py",
+        SERVICES_DIR / "workflow_agent_runs.py",
+        SERVICES_DIR / "workflow_repair_state.py",
+        SERVICES_DIR / "workflow_workspace_state.py",
+    }
+    for path in sorted(APP_DIR.rglob("*.py")):
+        if path in legacy_wrapper_paths:
+            continue
+        legacy_imports = sorted(_imported_modules(path) & MOVED_WORKFLOW_SERVICE_MODULES)
+        for module in legacy_imports:
+            violations.append(f"{path.relative_to(APP_DIR)} imports {module}")
+
+    assert violations == []