test: complete E2E test coverage — 106 tests#21
Open
HMAKT99 wants to merge 1 commit into
Open
Conversation
…total) DaemonCoordinatorTests (+3): - authLateResponseAfterTimeoutIsNoOp: confirms OnceContinuation handles late responses after timeout without crashing - authBLESendFailureResultsInImmediateFailure: fast-fails when BLE send returns false instead of waiting the full timeout - authResponseWithWrongDeviceIDIsIgnored: spoofed response with unknown deviceID is dropped; correct response still resolves auth EndToEndTests (+3): - fullEndToEndFailsWithBadSignature: wrong signing key -> PAM failure - fullEndToEndConcurrentRequests: 3 parallel PAM connections all succeed - fullEndToEndAuditEntryFields: validates every field of the audit entry ProximityMonitorTests (new file, +4): - Lock not triggered when monitor is disabled - Lock triggered after disconnect delay - Lock cancelled on reconnect before deadline - Lock cancelled on disable() before deadline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProximityMonitor(previously 0 tests)DaemonCoordinatorTests (+3)
authLateResponseAfterTimeoutIsNoOp— companion response after timeout is silently dropped;OnceContinuationdoes not double-resumeauthBLESendFailureResultsInImmediateFailure— BLE send failure fast-fails without waiting the full timeoutauthResponseWithWrongDeviceIDIsIgnored— spoofed response with unknowndeviceIDis dropped; correct response still winsEndToEndTests (+3)
fullEndToEndFailsWithBadSignature— signing with an unregistered key returns PAM failurefullEndToEndConcurrentRequests— 3 parallel PAM connections all succeed and produce 3 audit entriesfullEndToEndAuditEntryFields— validates every field of the audit entry (sessionID, surface, requestingProcess, result, authType, latencyMs, companionDevice)ProximityMonitorTests (new file, +4)
disable()before deadline firesTest plan
cd daemon && swift test→ 106 tests, 0 failures