Fix GitHub Action

Author: Glavo

.github/workflows/check.yml

@@ -29,7 +29,7 @@ jobs:
           distribution: 'temurin'
           java-version: '25'
       - name: Publish to Maven Central
-        run: ./gradlew --no-daemon --info publishToSonatype closeAndReleaseSonatypeStagingRepository -Phmcl.channel=$HMCL_UPDATE_CHANNEL
+        run: ./gradlew --no-daemon --info upload -Phmcl.channel=$HMCL_UPDATE_CHANNEL
         env:
           SIGNING_KEY_ID: ${{ secrets.signingKeyId }}
           SIGNING_PASSWORD: ${{ secrets.signingPassword }}

build.gradle.kts

@@ -26,27 +26,19 @@ CheckUpdate.apply(project, hmclChannel)
 val hmclVersion: String = ext.get(CheckUpdate.HMCL_VERSION).toString()
 val hmclDownloadBaseUri: String = ext.get(CheckUpdate.HMCL_DOWNLOAD_BASE_URI).toString()
 
+val existing = CheckExisting.checkExisting(hmclChannel, hmclDownloadBaseUri)
+
 version = hmclVersion
 
 val downloadDir = layout.buildDirectory.dir("downloads")
 
-val checkExisting by tasks.registering(CheckExisting::class) {
-    version.set(hmclVersion)
-    channel.set(hmclChannel)
-}
-
-
-tasks.named("publishToSonatype") {
-    dependsOn(checkExisting)
-}
-
-tasks.named("closeAndReleaseSonatypeStagingRepository") {
-    dependsOn(checkExisting)
+val upload by tasks.registering {
+    if (!existing) {
+        dependsOn("publishToSonatype", "closeAndReleaseSonatypeStagingRepository")
+    }
 }
 
 val downloadArtifacts by tasks.registering(Download::class) {
-    dependsOn(checkExisting)
-
     src("$hmclDownloadBaseUri/HMCL-$hmclVersion.jar")
     src("$hmclDownloadBaseUri/HMCL-$hmclVersion.jar.sha256")
 

buildSrc/src/main/java/org/glavo/hmcl/update/CheckExisting.java

@@ -22,7 +22,6 @@
 import org.gradle.api.logging.Logging;
 import org.gradle.api.provider.Property;
 import org.gradle.api.tasks.Input;
-import org.gradle.api.tasks.StopExecutionException;
 import org.gradle.api.tasks.TaskAction;
 import org.jetbrains.annotations.NotNull;
 import org.w3c.dom.Document;
@@ -36,21 +35,11 @@
 import java.net.http.HttpResponse;
 import java.util.regex.Pattern;
 
-public abstract class CheckExisting extends DefaultTask {
+public final class CheckExisting {
     private static final Logger LOGGER = Logging.getLogger(CheckExisting.class);
     private static final Pattern PATTERN = Pattern.compile("^[0-9]+\\.[0-9]+\\.[0-9]+(\\.[0-9]+)?$");
 
-    @Input
-    public abstract Property<@NotNull UpdateChannel> getChannel();
-
-    @Input
-    public abstract Property<@NotNull String> getVersion();
-
-    @TaskAction
-    public void run() throws Exception {
-        UpdateChannel channel = getChannel().get();
-
-        String version = getVersion().get();
+    public static boolean checkExisting(UpdateChannel channel, String version) throws Exception {
         if (!PATTERN.matcher(version).matches()) {
             throw new IllegalArgumentException("Bad HMCL version: " + version);
         }
@@ -71,9 +60,11 @@ public void run() throws Exception {
             Node item = versionList.item(i);
             if (version.equals(item.getFirstChild().getNodeValue())) {
                 LOGGER.quiet("{} already exists, no update required", version);
-                throw new StopExecutionException();
+                return true;
             }
         }
+
+        return false;
     }
 
 }