refactor: update Gson references to use SETTINGS_GSON in multiple classes

Author: Glavo

HMCL/src/main/java/org/jackhuang/hmcl/game/HMCLGameRepository.java

@@ -220,7 +220,7 @@ public void duplicateVersion(String srcId, String dstId, boolean copySaves) thro
     private GameSettings.Instance copyLocalGameSettings(String id) {
         GameSettings.Instance setting = getLocalGameSettings(id);
         if (setting != null) {
-            return JsonUtils.clone(LauncherSettings.GSON, setting, TypeToken.get(GameSettings.Instance.class));
+            return JsonUtils.clone(LauncherSettings.SETTINGS_GSON, setting, TypeToken.get(GameSettings.Instance.class));
         }
 
         GameSettings.Instance copied = new GameSettings.Instance();
@@ -267,7 +267,7 @@ private void loadLocalGameSettings(String id) {
 
         try {
             try (var reader = Files.newBufferedReader(file)) {
-                return LauncherSettings.GSON.fromJson(reader, GameSettings.Instance.class);
+                return LauncherSettings.SETTINGS_GSON.fromJson(reader, GameSettings.Instance.class);
             }
         } catch (Exception ex) {
             LOG.warning("Failed to load game setting " + file, ex);
@@ -457,7 +457,7 @@ public void saveGameSettings(String id) {
             LOG.warning("Failed to create directory: " + file.getParent(), e);
         }
 
-        FileSaver.save(file, LauncherSettings.GSON.toJson(localGameSettings.get(id)));
+        FileSaver.save(file, LauncherSettings.SETTINGS_GSON.toJson(localGameSettings.get(id)));
     }
 
     public LaunchOptions.Builder getLaunchOptions(String version, JavaRuntime javaVersion, Path gameDir, List<String> javaAgents, List<String> javaArguments, boolean makeLaunchScript) {

HMCL/src/main/java/org/jackhuang/hmcl/setting/Accounts.java

@@ -207,7 +207,7 @@ private static void loadGlobalAccountStorages() {
 
         try (Reader reader = Files.newBufferedReader(LEGACY_GLOBAL_ACCOUNTS_LOCATION)) {
             List<Map<Object, Object>> accounts =
-                    LauncherSettings.GSON.fromJson(reader, listTypeOf(mapTypeOf(Object.class, Object.class)));
+                    LauncherSettings.SETTINGS_GSON.fromJson(reader, listTypeOf(mapTypeOf(Object.class, Object.class)));
             return accounts != null ? AccountStorages.fromAccounts(accounts) : null;
         } catch (Throwable e) {
             LOG.warning("Failed to load legacy global accounts", e);

HMCL/src/main/java/org/jackhuang/hmcl/setting/GlobalConfig.java

@@ -33,15 +33,15 @@ public final class GlobalConfig extends ObservableSetting {
 
     @Nullable
     public static GlobalConfig fromJson(String json) throws JsonParseException {
-        return LauncherSettings.GSON.fromJson(json, GlobalConfig.class);
+        return LauncherSettings.SETTINGS_GSON.fromJson(json, GlobalConfig.class);
     }
 
     public GlobalConfig() {
         register();
     }
 
     public String toJson() {
-        return LauncherSettings.GSON.toJson(this);
+        return LauncherSettings.SETTINGS_GSON.toJson(this);
     }
 
     @SerializedName("agreementVersion")

HMCL/src/main/java/org/jackhuang/hmcl/setting/LauncherSettings.java

@@ -67,7 +67,7 @@ public final class LauncherSettings extends ObservableSetting {
     static final String SELECTED_INSTANCE_MEMBER_NAME = "selectedInstance";
 
     /// Gson instance used for launcher settings and related settings objects that depend on JavaFX properties.
-    public static final Gson GSON = new GsonBuilder()
+    public static final Gson SETTINGS_GSON = new GsonBuilder()
             .registerTypeAdapter(Path.class, PathTypeAdapter.INSTANCE)
             .registerTypeAdapter(UUID.class, UUIDTypeAdapter.INSTANCE)
             .registerTypeAdapter(GUID.class, GUIDTypeAdapter.INSTANCE)
@@ -89,7 +89,7 @@ public final class LauncherSettings extends ObservableSetting {
     /// @throws JsonParseException if the JSON cannot be deserialized as launcher settings
     @Nullable
     public static LauncherSettings fromJson(JsonObject json) throws JsonParseException {
-        return GSON.fromJson(json, LauncherSettings.class);
+        return SETTINGS_GSON.fromJson(json, LauncherSettings.class);
     }
 
     /// Creates empty launcher settings using current defaults.
@@ -100,7 +100,7 @@ public LauncherSettings() {
 
     /// Serializes these launcher settings to formatted JSON.
     public String toJson() {
-        return GSON.toJson(this);
+        return SETTINGS_GSON.toJson(this);
     }
 
     // Properties