Skip to content

Commit 83782f5

Browse files
authored
feat: 移动并简化 VersionPage.wrap 方法 (#5218)
1 parent a19f147 commit 83782f5

7 files changed

Lines changed: 13 additions & 24 deletions

File tree

HMCL/src/main/java/org/jackhuang/hmcl/ui/FXUtils.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,14 @@ public static void limitSize(ImageView imageView, double maxWidth, double maxHei
299299
});
300300
}
301301

302+
public static Node wrap(Node node) {
303+
return limitingSize(node, 30, 20);
304+
}
305+
306+
public static Node wrap(SVG svg) {
307+
return wrap(svg.createIcon(20));
308+
}
309+
302310
private static class ListenerPair<T> {
303311
private final ObservableValue<T> value;
304312
private final ChangeListener<? super T> listener;

HMCL/src/main/java/org/jackhuang/hmcl/ui/account/AccountListPage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
import java.util.Locale;
5555

5656
import static org.jackhuang.hmcl.setting.ConfigHolder.globalConfig;
57-
import static org.jackhuang.hmcl.ui.versions.VersionPage.wrap;
57+
import static org.jackhuang.hmcl.ui.FXUtils.wrap;
5858
import static org.jackhuang.hmcl.util.i18n.I18n.i18n;
5959
import static org.jackhuang.hmcl.util.javafx.ExtendedProperties.createSelectedItemPropertyFor;
6060
import static org.jackhuang.hmcl.util.logging.Logger.LOG;

HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/AdvancedListBox.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import org.jackhuang.hmcl.ui.SVG;
3131
import org.jackhuang.hmcl.ui.animation.ContainerAnimations;
3232
import org.jackhuang.hmcl.ui.animation.TransitionPane;
33-
import org.jackhuang.hmcl.ui.versions.VersionPage;
3433

3534
import java.util.function.Consumer;
3635

@@ -75,7 +74,7 @@ private AdvancedListItem createNavigationDrawerItem(String title, SVG leftGraphi
7574
item.setActionButtonVisible(false);
7675
item.setTitle(title);
7776
if (leftGraphic != null) {
78-
item.setLeftGraphic(VersionPage.wrap(leftGraphic));
77+
item.setLeftGraphic(FXUtils.wrap(leftGraphic));
7978
}
8079
return item;
8180
}

HMCL/src/main/java/org/jackhuang/hmcl/ui/main/RootPage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
import java.util.stream.Collectors;
6868

6969
import static org.jackhuang.hmcl.ui.FXUtils.runInFX;
70-
import static org.jackhuang.hmcl.ui.versions.VersionPage.wrap;
70+
import static org.jackhuang.hmcl.ui.FXUtils.wrap;
7171
import static org.jackhuang.hmcl.util.i18n.I18n.i18n;
7272
import static org.jackhuang.hmcl.util.logging.Logger.LOG;
7373

HMCL/src/main/java/org/jackhuang/hmcl/ui/profile/ProfileListItemSkin.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import org.jackhuang.hmcl.ui.SVG;
2929
import org.jackhuang.hmcl.ui.construct.RipplerContainer;
3030
import org.jackhuang.hmcl.ui.construct.TwoLineListItem;
31-
import org.jackhuang.hmcl.ui.versions.VersionPage;
3231

3332
public class ProfileListItemSkin extends SkinBase<ProfileListItem> {
3433
private final PseudoClass SELECTED = PseudoClass.getPseudoClass("selected");
@@ -47,7 +46,7 @@ public ProfileListItemSkin(ProfileListItem skinnable) {
4746

4847
FXUtils.onClicked(getSkinnable(), () -> getSkinnable().setSelected(true));
4948

50-
Node left = VersionPage.wrap(SVG.FOLDER);
49+
Node left = FXUtils.wrap(SVG.FOLDER);
5150
root.setLeft(left);
5251
BorderPane.setAlignment(left, Pos.CENTER_LEFT);
5352

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/GameListPage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public GameListPage() {
7070
addProfileItem.getStyleClass().add("navigation-drawer-item");
7171
addProfileItem.setTitle(i18n("profile.new"));
7272
addProfileItem.setActionButtonVisible(false);
73-
addProfileItem.setLeftGraphic(VersionPage.wrap(SVG.ADD_CIRCLE));
73+
addProfileItem.setLeftGraphic(FXUtils.wrap(SVG.ADD_CIRCLE));
7474
addProfileItem.setOnAction(e -> Controllers.navigate(new ProfilePage(null)));
7575

7676
pane.setFitToWidth(true);

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/VersionPage.java

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,8 @@
2121
import javafx.application.Platform;
2222
import javafx.beans.binding.Bindings;
2323
import javafx.beans.property.*;
24-
import javafx.geometry.Insets;
25-
import javafx.geometry.Pos;
2624
import javafx.scene.Node;
2725
import javafx.scene.layout.Priority;
28-
import javafx.scene.layout.StackPane;
2926
import javafx.scene.layout.VBox;
3027
import org.jackhuang.hmcl.event.EventBus;
3128
import org.jackhuang.hmcl.event.EventPriority;
@@ -305,20 +302,6 @@ protected Skin(VersionPage control) {
305302
}
306303
}
307304

308-
public static Node wrap(Node node) {
309-
StackPane stackPane = new StackPane();
310-
stackPane.setAlignment(Pos.CENTER);
311-
FXUtils.setLimitWidth(stackPane, 30);
312-
FXUtils.setLimitHeight(stackPane, 20);
313-
stackPane.setPadding(new Insets(0, 0, 0, 0));
314-
stackPane.getChildren().setAll(node);
315-
return stackPane;
316-
}
317-
318-
public static Node wrap(SVG svg) {
319-
return wrap(svg.createIcon(20));
320-
}
321-
322305
public interface VersionLoadable {
323306
void loadVersion(Profile profile, String version);
324307
}

0 commit comments

Comments
 (0)