Use GUID v7 for new profile IDs

Author: Glavo

HMCL/src/main/java/org/jackhuang/hmcl/setting/GameSettings.java

@@ -120,13 +120,13 @@ protected Instance createInstance() {
     public static final class Preset extends GameSettings {
         /// Creates a preset with the given identity.
         public Preset(GUID id) {
-            this(id, true);
+            register();
+            this.id.setValue(Objects.requireNonNull(id));
         }
 
         /// Creates a preset with the given identity.
-        private Preset(GUID id, boolean checkNonNil) {
+        private Preset() {
             register();
-            this.id.setValue(checkNonNil ? requireNonNilId(id) : Objects.requireNonNull(id));
         }
 
         /// The stable preset ID.
@@ -138,15 +138,6 @@ public SettingProperty<GUID> idProperty() {
             return id;
         }
 
-        /// Returns a non-nil preset ID or throws when the value is not usable.
-        private static GUID requireNonNilId(GUID id) {
-            Objects.requireNonNull(id);
-            if (GUID.NIL.equals(id)) {
-                throw new IllegalArgumentException("Preset ID cannot be nil");
-            }
-            return id;
-        }
-
         /// The display name of this preset.
         @SerializedName("name")
         private final SettingProperty<String> name = newSettingProperty("name", "");
@@ -169,7 +160,7 @@ public SettingProperty<DefaultIsolationType> defaultIsolationTypeProperty() {
         public static final class Adapter extends ObservableSetting.Adapter<@Nullable Preset> {
             @Override
             protected Preset createInstance() {
-                return new Preset(GUID.NIL, false);
+                return new Preset();
             }
 
             @Override

HMCL/src/main/java/org/jackhuang/hmcl/setting/Profile.java

@@ -75,7 +75,7 @@ public GUID getId() {
 
     /// Sets the stable profile ID.
     public void setId(GUID id) {
-        this.id.set(requireNonNilId(id));
+        this.id.set(Objects.requireNonNull(id));
     }
 
     private final StringProperty selectedVersion = new SimpleStringProperty();
@@ -136,7 +136,7 @@ public Profile(GUID id, String name, PortablePath path) {
 
     /// Creates a profile with an explicit stable ID.
     Profile(GUID id, String name, PortablePath path, @Nullable String selectedVersion) {
-        this.id.set(requireNonNilId(id));
+        this.id.set(Objects.requireNonNull(id));
         this.name = new SimpleStringProperty(this, "name", name);
         this.path = new SimpleObjectProperty<>(this, "path", Objects.requireNonNull(path));
         repository = new HMCLGameRepository(this, path.toPath());
@@ -149,15 +149,6 @@ public Profile(GUID id, String name, PortablePath path) {
         addPropertyChangedListener(onInvalidating(this::invalidate));
     }
 
-    /// Returns a non-nil profile ID or throws when the value is not usable.
-    private static GUID requireNonNilId(GUID id) {
-        Objects.requireNonNull(id);
-        if (GUID.NIL.equals(id)) {
-            throw new IllegalArgumentException("Profile ID cannot be nil");
-        }
-        return id;
-    }
-
     private void checkSelectedVersion() {
         runInFX(() -> {
             if (!repository.isLoaded()) return;

HMCL/src/test/java/org/jackhuang/hmcl/setting/GameDirectoriesTest.java

@@ -86,12 +86,9 @@ public void storesProfilePath() {
         assertFalse(deserialized.getPath().isAbsolute());
     }
 
-    /// Tests that profiles must be initialized with a non-nil ID.
+    /// Tests that profiles must be deserialized with a non-nil ID.
     @Test
     public void rejectsNilProfileId() {
-        assertThrows(IllegalArgumentException.class,
-                () -> new Profile(GUID.NIL, "Dev", PortablePath.of("versions/Dev")));
-
         assertThrows(JsonParseException.class, () -> JsonUtils.GSON.fromJson("""
                 {
                   "id": "00000000-0000-0000-0000-000000000000",

HMCL/src/test/java/org/jackhuang/hmcl/setting/GameSettingsPresetsTest.java

@@ -43,11 +43,9 @@ public void storesDefaultGameSettingsPresetInConfig() {
         assertEquals(id.toString(), serialized.get(Config.DEFAULT_GAME_SETTINGS_PRESET_MEMBER_NAME).getAsString());
     }
 
-    /// Tests that presets must be initialized with a non-nil ID.
+    /// Tests that presets must be deserialized with a non-nil ID.
     @Test
     public void rejectsNilPresetId() {
-        assertThrows(IllegalArgumentException.class, () -> new GameSettings.Preset(GUID.NIL));
-
         assertThrows(JsonParseException.class, () -> JsonUtils.GSON.fromJson("""
                 {
                   "id": "00000000-0000-0000-0000-000000000000"