feat: 优化世界管理与世界信息页面 by Mine-diamond · Pull Request #5215 · HMCL-dev/HMCL

Mine-diamond · 2026-01-13T02:38:55Z

继续 #4823 对世界信息界面进行的优化

世界管理：

添加WorldRefreshable 接口，当页面再次导航进入时刷新子页面
对于获取只读属性，现在使用isReadOnlyProperty而不是只能返回布尔值
实现Refreshable.refresh()方法和Refreshable.refreshableProperty()方法
"生成启动脚本"按钮移至管理菜单
优化WorldManagePage的代码，将构建皮肤的代码拆分到皮肤类中
字段id修改为versionId以更好匹配它的含义

版本特性解析：

将WorldManagePage/WorldListItemSkin/DefaultLauncher中的部分硬编码的版本判断移动到World和ChunkBaseApp类中
在World类中添加supportsDatapacks()/supportsQuickPlay()/supportsQuickPlay(GameVersionNumber) 方法
在ChunkBaseApp类中添加supportEndCity(World) 方法

世界信息页面：

bug 修复：

修复了在部分版本无法正确获取维度信息的bug
修复了种子现实按钮在切换图标时位置发生变化的bug
修复了部分信息项总是尝试保存而不会检查输入有效性的bug

修改：

将第一块信息的标题“基本信息”修改为“世界信息”
“游戏内时长”修改为“游戏时长”以更好的匹配它的作用，游戏时长现在显示为%d 天 %d 小时 %d 分钟而不是%s 天
添加世界出生点信息项
添加饱和度信息项

优化：

简化了床/重生锚位置信息项的实现
简化了游戏模式信息项的实现
修改各个辅助方法的名称使其更能表达自己的功能
修改各个字段的名称使之更能表达自己的作用
减少了setRightTextLabel需要的参数因为发现并不需要
提取更多样板代码到setRightTextField方法中以减少重复样板代码的带来的长度

世界列表页面：

将进入世界按钮暴露于世界列表
恢复缩进

数据包页面

现在当世界运行时禁用禁用/启用/删除按钮，并在添加数据包时提示reload

World类：

现在getWorlds方法返回List<World>而不是Stream<World>
现在isLocked()方法每次返回时计算而不缓存

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldListItem.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldListItemSkin.java

3gf8jv4dv · 2026-01-15T11:45:59Z

和 Issue #4868 类似，右上角的刷新图标也糊……

不过我发现，此时点击启动器右上角的最小化按钮，再从任务栏还原，就不糊了。

注：这两张一对比，最左侧的返回按钮也糊 :(

糊 🤔	不糊 😃

CC @Glavo

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldManagePage.java

Copilot

Pull request overview

This PR optimizes world management and world information pages, refactoring code structure, fixing bugs, and adding new features to improve maintainability and user experience.

Changes:

Refactored WorldManagePage to use the Skin pattern, moving UI construction from the page class to a separate Skin class
Fixed critical bug in dimension ID mapping (Nether and End dimension IDs were incorrect)
Added new information fields (world spawn point, saturation level) and improved time display format
Introduced WorldRefreshable interface and updated refresh mechanism for sub-pages

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
HMCLCore/src/main/java/org/jackhuang/hmcl/util/Lang.java	Added toFloatOrNull utility method
HMCLCore/src/main/java/org/jackhuang/hmcl/game/World.java	Added version support methods (supportDatapacks, supportQuickPlay), changed getWorlds return type from Stream to List, made isLocked() compute on each call
HMCLCore/src/main/java/org/jackhuang/hmcl/launch/DefaultLauncher.java	Refactored hardcoded version checks to use World.supportQuickPlay()
HMCL/src/main/java/org/jackhuang/hmcl/util/ChunkBaseApp.java	Added supportEndCity() method to centralize version checking
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldManagePage.java	Major refactoring: extracted UI construction to Skin class, added refresh mechanism, renamed id to versionId, introduced WorldRefreshable interface
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldListPage.java	Added launch button to world list items, simplified code, improved formatting
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldInfoPage.java	Fixed dimension ID mapping bug, added world spawn and saturation fields, improved time format, simplified field binding code
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldBackupsPage.java	Changed from using boolean isReadOnly to BooleanProperty for reactive UI updates
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DatapackListPage.java	Added toast notification for datapack reload, disabled buttons when world is running
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DatapackListPageSkin.java	Bound button disable states to isReadOnlyProperty
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldManageUIUtils.java	Updated exception handling to catch WorldLockedException instead of IOException
I18N*.properties files	Updated translations for new features (world spawn point, saturation, improved time format)

Comments suppressed due to low confidence (2)

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DatapackListPage.java:80

This method overrides WorldRefreshable.refresh; it is advisable to add an Override annotation.

    public void refresh() {

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldBackupsPage.java:82

This method overrides WorldRefreshable.refresh; it is advisable to add an Override annotation.

    public void refresh() {

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldListPage.java

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldInfoPage.java

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 8 comments.

Comments suppressed due to low confidence (2)

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DatapackListPage.java:80

This method overrides WorldRefreshable.refresh; it is advisable to add an Override annotation.

    public void refresh() {

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldBackupsPage.java:82

This method overrides WorldRefreshable.refresh; it is advisable to add an Override annotation.

    public void refresh() {

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-29T13:56:53Z

 world.info.player.spawn=Точка возрождения
 world.info.player.xp_level=Уровень опыта
 world.info.random_seed=Ключ генератора мира
-world.info.time=Время игры
-world.info.time.format=%s дн.
 world.locked=В эксплуатации


This locale file no longer defines world.info.time / world.info.time.format, but WorldInfoPage still uses those keys for the played-time row. This will cause missing-translation output (fallback/key shown) when running in ru. Please add updated translations (and the new world.info.spawn / world.info.player.food_saturation_level keys if you want full coverage).

Copilot · 2026-01-29T13:56:54Z

 world.info.player.spawn=Ubicación de desove
 world.info.player.xp_level=Nivel de experiencia
 world.info.random_seed=Semilla
-world.info.time=Tiempo de juego
-world.info.time.format=%s días
 world.locked=En uso


This locale file no longer defines world.info.time / world.info.time.format, but WorldInfoPage still uses those keys for the played-time row. This will cause missing-translation output (fallback/key shown) when running in es. Please add updated translations (and the new world.info.spawn / world.info.player.food_saturation_level keys if you want full coverage).

Copilot · 2026-01-29T13:56:54Z

 world.info.player.spawn=موقع الظهور
 world.info.player.xp_level=مستوى الخبرة
 world.info.random_seed=البذرة
-world.info.time=وقت اللعبة
-world.info.time.format=%s أيام
 world.locked=قيد الاستخدام


This locale file no longer defines world.info.time / world.info.time.format, but WorldInfoPage still uses those keys for the played-time row. This will cause missing-translation output (fallback/key shown) when running in ar. Please add updated translations (and the new world.info.spawn / world.info.player.food_saturation_level keys if you want full coverage).

Copilot · 2026-01-29T13:56:54Z

 world.info.player.spawn=床/復生錨之所
 world.info.player.xp_level=經驗之層
 world.info.random_seed=種
-world.info.time=戲之時辰
-world.info.time.format=%s 日
 world.locked=見用


This locale file no longer defines world.info.time / world.info.time.format, but WorldInfoPage still uses those keys for the played-time row. This will cause missing-translation output (fallback/key shown) when running in lzh. Please add updated translations (and the new world.info.spawn / world.info.player.food_saturation_level keys if you want full coverage).

Copilot · 2026-01-29T13:56:54Z

+    private void updateWorldLevelDat(boolean pageFullyNavigated) {
+        try {
+            world.reloadLevelDat();
+        } catch (IOException e) {
+            LOG.warning("Can not load world level.dat of world: " + world.getFile(), e);
+            if (pageFullyNavigated) {
+                closePageForLoadingFail();
+            } else {
+                this.addEventHandler(Navigator.NavigationEvent.NAVIGATED, event -> closePageForLoadingFail());
            }


updateWorldLevelDat(false) adds a new Navigator.NavigationEvent.NAVIGATED handler every time reloadLevelDat() fails before the page is fully navigated, and the handler is never removed. If navigation retries happen, this can accumulate handlers and trigger duplicate close/dialog actions. Consider registering a single one-shot handler (remove after first fire), or store the handler reference and avoid re-adding it if already present.

Copilot · 2026-01-29T13:56:55Z

+    public boolean supportDatapacks() {
+        return getGameVersion() != null && getGameVersion().isAtLeast("1.13", "17w43a");
+    }
+
+    public boolean supportQuickPlay() {
+        return getGameVersion() != null && getGameVersion().isAtLeast("1.20", "23w14a");
+    }
+
+    public static boolean supportQuickPlay(GameVersionNumber gameVersionNumber) {
+        return gameVersionNumber != null && gameVersionNumber.isAtLeast("1.20", "23w14a");


PR description mentions adding supportsDatapacks() / supportsQuickPlay() methods, but the code adds supportDatapacks() / supportQuickPlay(). Please align the method names with the PR description (or update the PR description) to avoid confusion for reviewers and future contributors.

Copilot · 2026-01-29T13:56:55Z

 world.info.player.spawn=Місце появи
 world.info.player.xp_level=Рівень досвіду
 world.info.random_seed=Насіння
-world.info.time=Час гри
-world.info.time.format=%s днів
 world.locked=Використовується


This locale file no longer defines world.info.time / world.info.time.format, but WorldInfoPage still uses those keys for the played-time row. This will cause missing-translation output (fallback/key shown) when running in uk. Please add updated translations (and the new world.info.spawn / world.info.player.food_saturation_level keys if you want full coverage).

feat: 优化世界信息页面

9dfd5b5

Mine-diamond marked this pull request as draft January 13, 2026 02:43

Mine-diamond added 2 commits January 13, 2026 12:52

feat: 添加饱食度信息项

1bd1e6c

feat: 添加世界出生点信息项

2271457

3gf8jv4dv reviewed Jan 13, 2026

View reviewed changes

Comment thread HMCL/src/main/resources/assets/lang/I18N.properties Outdated

Comment thread HMCL/src/main/resources/assets/lang/I18N.properties Outdated

feat: 添加WorldRefreshable 接口

4efe86b

Mine-diamond changed the title ~~feat: 优化世界信息页面~~ feat: 优化世界管理与世界信息页面 Jan 13, 2026

Mine-diamond and others added 19 commits January 13, 2026 17:15

Apply suggestions from code review

7472ac9

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

feat: 优化代码

3a10ccf

feat: 优化代码

a7a62ca

feat: 优化代码，将生成启动脚本按钮移至管理菜单

0815175

feat: 优化代码，将添加Skin类

b110a16

feat: 优化代码

df1df9a

fix: 修复未正确解析玩家位置的bug

46abde1

fix: 优化isReadOnly实现

bac1157

Merge branch 'main' into world-info

a9fc603

fix: 将WorldManagePage中的版本判断移动到World和ChunkBaseApp类中

9d52698

fix: 修复bug

3961d49

Merge branch 'main' into world-info

6ce5c29

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldListItem.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldListItemSkin.java

fix: 修复主线的修改逻辑冲突

210108b

feat: 优化代码

0c14b1a

feat: 优化世界名称更改

5cfccb3

feat: 世界列表界面显示启动按钮

82c423f

feat: 优化getWorlds方法

6abb99d

fix: 修复缩进问题

2af95d2

feat: update

5f0aff6

Mine-diamond added 3 commits January 15, 2026 20:14

feat: 部分id重命名为versionId

5fd9f82

Merge branch 'main' into world-info

f0ffb5b

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldManagePage.java

feat: 数据包页面在世界被占用时禁用一些功能

649202f

Copilot AI reviewed Jan 20, 2026

View reviewed changes

Mine-diamond and others added 8 commits January 20, 2026 20:33

fix: 应用copilot的修复建议

2a5fd92

Merge branch 'main' into world-info

3a2bb05

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldListPage.java

Merge branch 'main' into world-info

77861d3

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldInfoPage.java

fix: 修复合并时playerGameTypePane的问题

4ded1fe

update

1eaa1cb

update

abe50b2

update

7d32085

update

6865272

Glavo requested a review from Copilot January 29, 2026 13:50

Copilot started reviewing on behalf of Glavo January 29, 2026 13:50 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

Glavo and others added 13 commits January 29, 2026 22:00

update

16754de

update

2be0053

update

89c67f3

update

9855967

update

0902815

update

1a6b4c4

update

7fd70f1

update

e98ef05

update

26f85f2

update

0160044

update

cdb8700

update

655c417

feat: update

c7dec9e

Glavo approved these changes Jan 29, 2026

View reviewed changes

Glavo merged commit 27972b9 into HMCL-dev:main Jan 29, 2026
2 checks passed

Mine-diamond mentioned this pull request Feb 5, 2026

[Bug] 一个世界的「世界管理」页面内，左下角「管理 > 复制此世界」失败 #5440

Open

Mine-diamond deleted the world-info branch February 5, 2026 14:21

Mine-diamond mentioned this pull request Mar 24, 2026

feat: 优化世界管理 #5842

Open

Conversation

Mine-diamond commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

世界管理：

版本特性解析：

世界信息页面：

世界列表页面：

数据包页面

World类：

Uh oh!

Uh oh!

Uh oh!

3gf8jv4dv commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Mine-diamond commented Jan 13, 2026 •

edited

Loading

3gf8jv4dv commented Jan 15, 2026 •

edited

Loading