Skip to content

Fix #4934 返回页面时可能卡进空白页面 #5305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Glavo merged 2 commits into from
Jan 24, 2026
+3 −1
Merged

Fix #4934 返回页面时可能卡进空白页面 #5305

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39183f1
update
CiiLu Jan 24, 2026
11d6a6c
update
CiiLu Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion HMCL/src/main/java/org/jackhuang/hmcl/ui/animation/TransitionPane.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,9 @@ public void setContent(Node newView, AnimationProducer transition,
duration, interpolator);
newAnimation.setOnFinished(e -> {
setMouseTransparent(false);
getChildren().remove(previousNode);
if (previousNode != currentNode) {
getChildren().remove(previousNode);
}
Comment on lines 83 to +87

Copilot AI Jan 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onFinished can still run after a newer setContent(...) call has already started (or is about to start) another transition. In that case this callback may (a) call setMouseTransparent(false) too early for the newer transition, and (b) remove a node that a newer transition is currently animating (even if it’s not currentNode). Consider tracking a monotonically increasing transition/id (or storing the currently active Animation) and in onFinished only performing cleanup when this callback corresponds to the latest transition.

Copilot uses AI. Check for mistakes.

if (cacheHint != null) {
newView.setCache(false);
Expand Down
Loading