为“渲染器”添加描述#5514
Merged
Merged
Conversation
3gf8jv4dv
reviewed
Feb 11, 2026
Contributor
|
建议把Zink的“性能最好”改为“性能较好” 在不同系统 不同驱动下zink的性能表现有可能比默认好 大部分情况下比默认差 |
Contributor
Author
这里直接沿用了自 #2145 引入的旧文本,Glavo 当初这么写应该是有自己的考量,如果确实不适宜,我再调整一下 |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds per-option descriptions to the “Renderer” (settings.advanced.renderer) selector so the launcher UI can show explanatory subtitles for each renderer choice (restoring the pre-#4975 explanatory text via LineSelectButton descriptions).
Changes:
- Wire
LineSelectButton’ssetDescriptionConverterfor the renderer selector inAdvancedVersionSettingPage. - Add
settings.advanced.renderer.*.desci18n keys across multiple locales (and adjust the “Mesa LLVMpipe” label text in the fatal hint strings). - Update renderer option strings to align the visible label with the new description-based explanation.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| HMCL/src/main/resources/assets/lang/I18N.properties | Adds renderer option .desc keys for the base (English) bundle; updates fatal hint text. |
| HMCL/src/main/resources/assets/lang/I18N_ar.properties | Adds renderer option .desc keys; updates fatal hint text. |
| HMCL/src/main/resources/assets/lang/I18N_es.properties | Adds renderer option .desc keys; updates fatal hint text. |
| HMCL/src/main/resources/assets/lang/I18N_ja.properties | Adds renderer option .desc keys; updates fatal hint text. |
| HMCL/src/main/resources/assets/lang/I18N_lzh.properties | Adds renderer option .desc keys; updates fatal hint text. |
| HMCL/src/main/resources/assets/lang/I18N_ru.properties | Adds renderer option .desc keys; updates fatal hint text. |
| HMCL/src/main/resources/assets/lang/I18N_uk.properties | Adds renderer option .desc keys and fatal hint update, but currently has a duplicated settings.advanced.renderer.default key. |
| HMCL/src/main/resources/assets/lang/I18N_zh.properties | Adds renderer option .desc keys; updates fatal hint text. |
| HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties | Adds renderer option .desc keys; updates fatal hint text. |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/AdvancedVersionSettingPage.java | Enables renderer option subtitles via setDescriptionConverter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Glavo
approved these changes
Feb 17, 2026
Glavo
pushed a commit
to Glavo/HMCL
that referenced
this pull request
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LineSelectButton添加了为每一个项添加描述的能力,本 PR 将 #4975 前的“渲染器”文本作为描述信息重新添加到启动器内CC @3gf8jv4dv 需要检查日语翻译,因为在上面提及的 PR 之前,日语并没有针对
settings.advanced.renderer部分进行翻译