Skip to content

为“渲染器”添加描述#5514

Merged
Glavo merged 4 commits into
HMCL-dev:mainfrom
WhatDamon:renderer-descriptions
Feb 17, 2026
Merged

为“渲染器”添加描述#5514
Glavo merged 4 commits into
HMCL-dev:mainfrom
WhatDamon:renderer-descriptions

Conversation

@WhatDamon

Copy link
Copy Markdown
Contributor

LineSelectButton 添加了为每一个项添加描述的能力,本 PR 将 #4975 前的“渲染器”文本作为描述信息重新添加到启动器内

image

CC @3gf8jv4dv 需要检查日语翻译,因为在上面提及的 PR 之前,日语并没有针对 settings.advanced.renderer 部分进行翻译

Comment thread HMCL/src/main/resources/assets/lang/I18N_es.properties Outdated
Comment thread HMCL/src/main/resources/assets/lang/I18N_ja.properties Outdated
Comment thread HMCL/src/main/resources/assets/lang/I18N_ja.properties Outdated
Comment thread HMCL/src/main/resources/assets/lang/I18N_ja.properties Outdated
@WhatDamon WhatDamon requested a review from 3gf8jv4dv February 11, 2026 11:11

@3gf8jv4dv 3gf8jv4dv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@slmpc

slmpc commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

建议把Zink的“性能最好”改为“性能较好” 在不同系统 不同驱动下zink的性能表现有可能比默认好 大部分情况下比默认差

@WhatDamon

Copy link
Copy Markdown
Contributor Author

建议把Zink的“性能最好”改为“性能较好” 在不同系统 不同驱动下zink的性能表现有可能比默认好 大部分情况下比默认差

这里直接沿用了自 #2145 引入的旧文本,Glavo 当初这么写应该是有自己的考量,如果确实不适宜,我再调整一下

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds per-option descriptions to the “Renderer” (settings.advanced.renderer) selector so the launcher UI can show explanatory subtitles for each renderer choice (restoring the pre-#4975 explanatory text via LineSelectButton descriptions).

Changes:

  • Wire LineSelectButton’s setDescriptionConverter for the renderer selector in AdvancedVersionSettingPage.
  • Add settings.advanced.renderer.*.desc i18n keys across multiple locales (and adjust the “Mesa LLVMpipe” label text in the fatal hint strings).
  • Update renderer option strings to align the visible label with the new description-based explanation.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
HMCL/src/main/resources/assets/lang/I18N.properties Adds renderer option .desc keys for the base (English) bundle; updates fatal hint text.
HMCL/src/main/resources/assets/lang/I18N_ar.properties Adds renderer option .desc keys; updates fatal hint text.
HMCL/src/main/resources/assets/lang/I18N_es.properties Adds renderer option .desc keys; updates fatal hint text.
HMCL/src/main/resources/assets/lang/I18N_ja.properties Adds renderer option .desc keys; updates fatal hint text.
HMCL/src/main/resources/assets/lang/I18N_lzh.properties Adds renderer option .desc keys; updates fatal hint text.
HMCL/src/main/resources/assets/lang/I18N_ru.properties Adds renderer option .desc keys; updates fatal hint text.
HMCL/src/main/resources/assets/lang/I18N_uk.properties Adds renderer option .desc keys and fatal hint update, but currently has a duplicated settings.advanced.renderer.default key.
HMCL/src/main/resources/assets/lang/I18N_zh.properties Adds renderer option .desc keys; updates fatal hint text.
HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties Adds renderer option .desc keys; updates fatal hint text.
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/AdvancedVersionSettingPage.java Enables renderer option subtitles via setDescriptionConverter.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread HMCL/src/main/resources/assets/lang/I18N_uk.properties Outdated
@Glavo Glavo merged commit b418c9d into HMCL-dev:main Feb 17, 2026
2 checks passed
@WhatDamon WhatDamon deleted the renderer-descriptions branch February 20, 2026 14:20
Glavo pushed a commit to Glavo/HMCL that referenced this pull request Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants