fix: 光影下载被错误地显示为 支持中英文搜索#5558
Merged
Merged
Conversation
CiiLu
force-pushed
the
www.bilibili.com/video/BV1VFZEBEEPo
branch
from
2a3dd88 to
c8a3fc3
Compare
Contributor
|
#5313 还有机会么 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the shader pack download list page so it is no longer displayed as supporting Chinese/English search (by disabling the supportChinese UI flag for shader packs).
Changes:
- Update
ofShaderPack(...)to construct the page instance, then disablesupportChinesebefore returning it.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+53
to
+55
| HMCLLocalizedDownloadListPage hmclLocalizedDownloadListPage = new HMCLLocalizedDownloadListPage(callback, versionSelection, RemoteModRepository.Type.SHADER_PACK, null, ModrinthRemoteModRepository.SHADER_PACKS); | ||
| hmclLocalizedDownloadListPage.supportChinese.set(false); | ||
| return hmclLocalizedDownloadListPage; |
There was a problem hiding this comment.
Local variable name hmclLocalizedDownloadListPage is overly verbose and repeats the type name; a shorter name like page (consistent with other factory methods in this class) would improve readability while keeping the same behavior.
Suggested change
| HMCLLocalizedDownloadListPage hmclLocalizedDownloadListPage = new HMCLLocalizedDownloadListPage(callback, versionSelection, RemoteModRepository.Type.SHADER_PACK, null, ModrinthRemoteModRepository.SHADER_PACKS); | |
| hmclLocalizedDownloadListPage.supportChinese.set(false); | |
| return hmclLocalizedDownloadListPage; | |
| HMCLLocalizedDownloadListPage page = new HMCLLocalizedDownloadListPage(callback, versionSelection, RemoteModRepository.Type.SHADER_PACK, null, ModrinthRemoteModRepository.SHADER_PACKS); | |
| page.supportChinese.set(false); | |
| return page; |
Contributor
|
Glavo
added a commit
to Glavo/HMCL
that referenced
this pull request
Mar 29, 2026
Co-authored-by: Glavo <zjx001202@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.