Skip to content

fix: 光影下载被错误地显示为 支持中英文搜索 #5558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Glavo merged 2 commits into from
Feb 20, 2026
Merged

fix: 光影下载被错误地显示为 支持中英文搜索 #5558

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8a3fc3
update
CiiLu Feb 17, 2026
6c6fd6b
update
Glavo Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/HMCLLocalizedDownloadListPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ public static DownloadListPage ofResourcePack(DownloadPage.DownloadCallback call
}

public static DownloadListPage ofShaderPack(DownloadPage.DownloadCallback callback, boolean versionSelection) {
return new HMCLLocalizedDownloadListPage(callback, versionSelection, RemoteModRepository.Type.SHADER_PACK, null, ModrinthRemoteModRepository.SHADER_PACKS);
HMCLLocalizedDownloadListPage hmclLocalizedDownloadListPage = new HMCLLocalizedDownloadListPage(callback, versionSelection, RemoteModRepository.Type.SHADER_PACK, null, ModrinthRemoteModRepository.SHADER_PACKS);
hmclLocalizedDownloadListPage.supportChinese.set(false);
return hmclLocalizedDownloadListPage;
Comment thread
CiiLu marked this conversation as resolved.
Outdated

Copilot AI Feb 19, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local variable name hmclLocalizedDownloadListPage is overly verbose and repeats the type name; a shorter name like page (consistent with other factory methods in this class) would improve readability while keeping the same behavior.

Suggested change
HMCLLocalizedDownloadListPage hmclLocalizedDownloadListPage = new HMCLLocalizedDownloadListPage(callback, versionSelection, RemoteModRepository.Type.SHADER_PACK, null, ModrinthRemoteModRepository.SHADER_PACKS);
hmclLocalizedDownloadListPage.supportChinese.set(false);
return hmclLocalizedDownloadListPage;
HMCLLocalizedDownloadListPage page = new HMCLLocalizedDownloadListPage(callback, versionSelection, RemoteModRepository.Type.SHADER_PACK, null, ModrinthRemoteModRepository.SHADER_PACKS);
page.supportChinese.set(false);
return page;

Copilot uses AI. Check for mistakes.
}

private HMCLLocalizedDownloadListPage(DownloadPage.DownloadCallback callback, boolean versionSelection, RemoteModRepository.Type type, CurseForgeRemoteModRepository curseForge, ModrinthRemoteModRepository modrinth) {
Expand Down