Open
Conversation
Contributor
CiiLu
commented
Feb 24, 2026
CiiLu
commented
Glavo
reviewed
Apr 5, 2026
| // ListViewBehavior would consume ESC pressed event, preventing us from handling it, so we ignore it here | ||
| ignoreEvent(listView, KeyEvent.KEY_PRESSED, e -> e.getCode() == KeyCode.ESCAPE); | ||
|
|
||
| listView.setFixedCellSize(60); |
Member
There was a problem hiding this comment.
感觉设置一个硬编码的高度不是很合适，我担心会在一些字体设置下出问题。
Member
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the DownloadListPage to handle null descriptions and normalize line breaks by replacing newlines with spaces. The review feedback recommends using a regex to handle all line ending types (Unix and Windows) to avoid UI issues from leftover carriage returns.
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadListPage.java
Outdated
Show resolved
Hide resolved
…Page.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.