rename NEO_FORGED to NEO_FORGE#6008
Merged
Glavo merged 1 commit intoHMCL-dev:mainfrom Apr 26, 2026
Merged
Conversation
Contributor
CiiLu
commented
Apr 26, 2026
CiiLu
commented
NeoForged 是 NeoForge 的开发团队
应该没有序列化兼容性问题
Member
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request performs a global rename of the mod loader type from NEO_FORGED to NEO_FORGE across the codebase, including UI components, metadata readers, and core logic. A review comment suggests adding @SerializedName with an alternate value to the ModLoaderType enum to maintain backward compatibility for persisted data that may still use the old naming convention.
Glavo
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.