Fix 5963: 愚人节版本 Minecraft 2.0 的 Legacy Fabric 下载列表为空#6009
Merged
Conversation
Contributor
Wulian233
commented
Apr 26, 2026
Member
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a version normalization mechanism for Legacy Fabric versions, specifically converting the '2point0_' prefix to '2.0_' for internal storage while retaining the original metadata version for API calls. A review comment suggests enhancing the robustness of the normalizeVersion method to handle cases where the version string might be exactly '2point0' without a trailing underscore.
Comment on lines
+77
to
+81
| private static String normalizeVersion(String version) { | ||
| return version.startsWith("2point0_") | ||
| ? "2.0_" + version.substring("2point0_".length()) | ||
| : version; | ||
| } |
Contributor
There was a problem hiding this comment.
这个 normalizeVersion 方法目前仅处理了带有下划线的前缀 2point0_。虽然目前 Legacy Fabric 的 Meta API 可能主要返回这种格式,但为了提高代码的健壮性,建议也处理一下不带下划线的情况(例如直接是 2point0),以防未来 API 返回格式发生变化。
Suggested change
| private static String normalizeVersion(String version) { | |
| return version.startsWith("2point0_") | |
| ? "2.0_" + version.substring("2point0_".length()) | |
| : version; | |
| } | |
| private static String normalizeVersion(String version) { | |
| if (version.startsWith("2point0_")) { | |
| return "2.0_" + version.substring("2point0_".length()); | |
| } | |
| return "2point0".equals(version) ? "2.0" : version; | |
| } |
Glavo
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.