Fixed wrong skin review model#6046
Merged
Glavo merged 19 commits intoHMCL-dev:mainfrom May 4, 2026
Merged
Conversation
WhatDamon
reviewed
May 3, 2026
Glavo
approved these changes
May 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect UV mapping in the skin preview player model rendering (Issue #5890) by correcting left/right face handling in the 3D skin mesh generation.
Changes:
- Swap LEFT/RIGHT face X translation directions in
SkinMultipleCubesso faces are positioned on the correct side of the model. - Swap the LEFT/RIGHT face triangle definitions in
SkinCube.Model#createFaces()to align UVs with the correct cube sides.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| HMCL/src/main/java/org/jackhuang/hmcl/ui/skin/SkinMultipleCubes.java | Corrects LEFT/RIGHT face placement by flipping X translations. |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/skin/SkinCube.java | Corrects LEFT/RIGHT face triangle/UV mapping by swapping face definitions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Glavo
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5890