修复无法用中文搜索游戏内容的问题#6129
Open
Glavo wants to merge 1 commit into
Open
Conversation
Member
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the search logic in LocalizedRemoteModRepository.java to use a LinkedHashSet for search filters and implements a sequential search strategy that tries keywords individually until results are found. Feedback indicates that this approach breaks pagination consistency because different pages may return results for different keywords when a pageOffset is applied.
Comment on lines
+72
to
+78
| for (String englishSearchFilter : englishSearchFiltersSet) { | ||
| searchResult = getBackedRemoteModRepository().search(downloadProvider, gameVersion, category, pageOffset, pageSize, englishSearchFilter, getBackedRemoteModRepositorySortOrder(), sortOrder); | ||
| remoteMods = searchResult.getUnsortedResults().toList(); | ||
| if (!remoteMods.isEmpty()) { | ||
| break; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
顺序尝试多个候选关键词的搜索策略虽然提高了首页搜索的准确性，但会导致分页逻辑失效。如果第一个候选关键词的结果总数少于 pageOffset，程序会尝试下一个关键词，这使得不同页码的结果可能属于不同的搜索目标，导致分页体验不连贯。建议在文档中说明此限制，或者考虑在 pageOffset > 0 时采用不同的处理逻辑。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.