CI: Add PDAF builds (#82)

Adding CI builds for
- eCLM-ParFlow-PDAF
- CLM3.5-ParFlow-PDAF

Changes in TSMP2
- BuildParflow: Add `-Wno-unused-variable` for PDAF-related builds
- BuildPDAFMODEL: More sophisticated library loading for SLURM and HYPRE

Update of PDAF
- mainly switching of CLM-standalone code in interface for coupled build

### More information on ParFlow-Compiler option `-Wno-unused-variable` for PDAF-builds

Error
```
parflow_pdaf/pfsimulator/parflow_lib/solver_richards.c:1817:16: error:
unused variable ‘pfl_start’ [-Werror=unused-variable]
```

Background: In `PseudoAdvanceRichards`, there are many unused
variables, which make sense for diffing with `AdvanceRichards`.

Author: jjokella

.github/workflows/CI.yml

@@ -36,25 +36,25 @@ jobs:
 #        - {
 #            name: "CLM3.5-PDAF",
 #            use_oasis: "False",
-#            model_opts: "CLM35 PDAF"
+#            model_opts: "CLM3.5 PDAF"
 #          }
         - {
             name: "eCLM-PDAF",
             use_oasis: "False",
             model_opts: "eCLM PDAF"
           }
-#        - {
-#            name: "CLM3.5-ParFlow-PDAF",
-#            use_oasis: "True",
-#            parflow_dir: "parflow_pdaf",
-#            model_opts: "CLM35 ParFlow PDAF"
-#          }
-#        - {
-#            name: "eCLM-ParFlow-PDAF",
-#            use_oasis: "True",
-#            parflow_dir: "parflow_pdaf",
-#            model_opts: "eCLM ParFlow PDAF"
-#         }
+        - {
+            name: "CLM3.5-ParFlow-PDAF",
+            use_oasis: "True",
+            parflow_dir: "parflow_pdaf",
+            model_opts: "CLM3.5 ParFlow PDAF"
+          }
+        - {
+            name: "eCLM-ParFlow-PDAF",
+            use_oasis: "True",
+            parflow_dir: "parflow_pdaf",
+            model_opts: "eCLM ParFlow PDAF"
+          }
     env:
       SYSTEMNAME: UBUNTU
       STAGE: 24.04

cmake/BuildPDAFMODEL.cmake

@@ -100,8 +100,27 @@ if(DEFINED PARFLOW_SRC)
   list(APPEND PDAF_LIBS "-L${CMAKE_INSTALL_PREFIX}/lib -lpfsimulator -lamps -lpfkinsol -lgfortran -lcjson")
   # GPU
   # list(APPEND PDAF_LIBS "-L${CMAKE_INSTALL_PREFIX}/rmm/lib -lstdc++ -lcudart -lrmm -lnvToolsExt")
-  list(APPEND PDAF_LIBS "-L${HYPRE_ROOT}/lib -lHYPRE")
-  list(APPEND PDAF_LIBS "-L/lib64 -lslurm -lstdc++")
+
+  # HYPRE lib
+  find_library(HYPRE_LIB NAMES HYPRE
+    HINTS
+      ${HYPRE_ROOT}/lib
+      $ENV{HYPRE_ROOT}/lib
+      $ENV{EBROOTHYPRE}/lib
+  )
+  if(HYPRE_LIB)
+    list(APPEND PDAF_LIBS "${HYPRE_LIB}")
+  else()
+    message(WARNING "BuildPDAFMODEL: HYPRE library not found. Set HYPRE_ROOT or EBROOTHYPRE if needed.")
+  endif()
+
+  # Unconditional loading of stdc++
+  list(APPEND PDAF_LIBS "-lstdc++")
+
+  # SLURM library if enabled (typically on HPC-system)
+  if(ENABLE_SLURM)
+    list(APPEND PDAF_LIBS "-lslurm")
+  endif()
 endif()
 
 # Join list of libraries

cmake/BuildParFlow.cmake

@@ -6,6 +6,7 @@ if(DEFINED eCLM_SRC)
 elseif(DEFINED CLM35_SRC)
     list(APPEND PF_CLM_FLAGS -DPARFLOW_AMPS_LAYER=oas3
                              -DOAS3_ROOT=${OASIS_ROOT}
+                             -DPARFLOW_HAVE_ECLM=OFF
                              -DPARFLOW_HAVE_CLM=OFF)
 else()
     # use ParFlow's internal CLM
@@ -41,6 +42,10 @@ endif()
 if(CMAKE_C_COMPILER_ID STREQUAL "GNU")
     # Flags were based from https://github.com/parflow/parflow/blob/c8aa8d7140db19153194728b8fa9136b95177b6d/.github/workflows/linux.yml#L486
     set(PF_CFLAGS "-Wall -Werror -Wno-unused-result -Wno-unused-function -Wno-stringop-overread")
+    if(${PDAF})
+      # parflow-pdaf fork currently ignores unused variables
+      string(APPEND PF_CFLAGS " -Wno-unused-variable")
+    endif()
     # Silence arch-specific compiler warnings
     if (${CMAKE_SYSTEM_PROCESSOR} MATCHES "arm64|aarch64")
       string(APPEND PF_CFLAGS " -Wno-maybe-uninitialized")