eCLM-PDAF: Remove Intel-Debug-Flag "-check all" + Debug builds in CI (#70)

* SetBuildoptions: remove `-check all` from debug flags

We are trying to fix the following problem and suspect that it comes
from the `-check all` flags.
```
==22279==WARNING: MemorySanitizer: use-of-uninitialized-value
```

In the future there could maybe be a more fine-grained handling of
checks.


* CI: Builds with build type "DEBUG"

Author: jjokella

.github/workflows/CI.yml

@@ -13,20 +13,47 @@ jobs:
         config:
         - {
             name: "eCLM-Standalone",
+            build_type: "RELEASE",
+            use_oasis: "False",
+            coup_oas_icon: "False",
+            coup_oas_pfl: "False",
+            use_pdaf: "False"
+          }
+        - {
+            name: "eCLM-Standalone_DEBUG",
+            build_type: "DEBUG",
             use_oasis: "False",
             coup_oas_icon: "False",
             coup_oas_pfl: "False",
             use_pdaf: "False"
           }
         - {
             name: "eCLM-ParFlow-ICON",
+            build_type: "RELEASE",
+            use_oasis: "True",
+            coup_oas_icon: "True",
+            coup_oas_pfl: "True",
+            use_pdaf: "False"
+          }
+        - {
+            name: "eCLM-ParFlow-ICON_DEBUG",
+            build_type: "DEBUG",
             use_oasis: "True",
             coup_oas_icon: "True",
             coup_oas_pfl: "True",
             use_pdaf: "False"
           }
         - {
             name: "eCLM-PDAF",
+            build_type: "RELEASE",
+            use_oasis: "False",
+            coup_oas_icon: "False",
+            coup_oas_pfl: "False",
+            use_pdaf: "True"
+          }
+        - {
+            name: "eCLM-PDAF_DEBUG",
+            build_type: "DEBUG",
             use_oasis: "False",
             coup_oas_icon: "False",
             coup_oas_pfl: "False",
@@ -77,7 +104,7 @@ jobs:
       - name: Configure eCLM
         run: |
           cmake -S src -B $BUILD_DIR                                \
-                -DCMAKE_BUILD_TYPE="RELEASE"                        \
+                -DCMAKE_BUILD_TYPE=${{ matrix.config.build_type }}  \
                 -DCMAKE_INSTALL_PREFIX=$INSTALL_DIR                 \
                 -DCMAKE_PREFIX_PATH="$HOME/.local"                  \
                 -DCMAKE_C_COMPILER=$CC                              \

cmake/SetBuildOptions.cmake

@@ -35,7 +35,14 @@ elseif(COMPILER STREQUAL "Intel" OR COMPILER STREQUAL "IntelLLVM")
     set(CMAKE_C_FLAGS_DEBUG "-O0 -g")
     set(CMAKE_C_FLAGS_RELEASE "-O2 -debug minimal")
     set(CMAKE_Fortran_FLAGS "-free -qno-opt-dynamic-align -ftz -traceback -convert big_endian -assume byterecl -assume realloc_lhs -fp-model source -qopenmp")
-    set(CMAKE_Fortran_FLAGS_DEBUG "-O0 -g -fpe0 -check all")
+    if(USE_PDAF)
+      # PDAF does not pass all checks from "-check all"
+      # TODO: Resolve the PDAF/non-PDAF difference by either adapting
+      # the compile options or debugging the source code
+      set(CMAKE_Fortran_FLAGS_DEBUG "-O0 -g -fpe0") #-check all
+    else()
+      set(CMAKE_Fortran_FLAGS_DEBUG "-O0 -g -fpe0 -check all")
+    endif()
     set(CMAKE_Fortran_FLAGS_RELEASE "-O2 -debug minimal")
 else()
     message(FATAL_ERROR "COMPILER='${COMPILER}' is not supported.")