Merge pull request opentripplanner#7353 from entur/parse_siri_xml_as_input_stream

leonardehrenfried · web-flow · commit 0cc7699cbe86 · 2026-03-02T13:26:39.000Z
Use zero-copy InputStream for SIRI XML parsing in PubSub updater
diff --git a/application/src/main/java/org/opentripplanner/updater/trip/siri/updater/google/GooglePubsubEstimatedTimetableSource.java b/application/src/main/java/org/opentripplanner/updater/trip/siri/updater/google/GooglePubsubEstimatedTimetableSource.java
@@ -251,7 +251,7 @@ private void deleteSubscription() {
   private Optional<ServiceDelivery> serviceDelivery(ByteString data) {
     Siri siri;
     try {
-      siri = SiriXml.parseXml(data.toStringUtf8());
+      siri = SiriXml.parseXml(data.newInput());
     } catch (XMLStreamException | JAXBException e) {
       throw new RuntimeException(e);
     }

Original file line number	Diff line number	Diff line change
`@@ -251,7 +251,7 @@ private void deleteSubscription() {`
`251`	`251`	`private Optional<ServiceDelivery> serviceDelivery(ByteString data) {`
`252`	`252`	`Siri siri;`
`253`	`253`	`try {`
`254`		`- siri = SiriXml.parseXml(data.toStringUtf8());`
	`254`	`+ siri = SiriXml.parseXml(data.newInput());`
`255`	`255`	`} catch (XMLStreamException \| JAXBException e) {`
`256`	`256`	`throw new RuntimeException(e);`
`257`	`257`	`}`