remove arriveBy matching departAt test because we no longer guarantees it.

Author: miklcct

application/src/main/java/org/opentripplanner/street/search/strategy/DominanceFunctions.java

@@ -76,6 +76,13 @@ public boolean betterOrEqualAndComparable(State a, State b) {
      *
      * More discussion: https://github.com/opentripplanner/OpenTripPlanner/issues/3393
      *
+     * In addition, the best result may not always be found because, due to the turn cost depending on
+     * where you come from, we may not always visit the node from the edge producing the optimal cost
+     * including turns. As a result of this non-optimality, we no longer guarantees that a depart-from
+     * and an arrive-by search will always return the same result.
+     *
+     * Issue: https://github.com/opentripplanner/OpenTripPlanner/issues/6768
+     *
      * == Bicycles ==
      *
      * We used to allow also loops for bicycles as turn restrictions also apply to them, however

application/src/test/java/org/opentripplanner/routing/algorithm/mapping/BikeRentalSnapshotTest.java

@@ -67,7 +67,7 @@ public void directBikeRental() {
       .withTo(p2)
       .buildRequest();
 
-    expectArriveByToMatchDepartAtAndSnapshot(request);
+    expectRequestResponseToMatchSnapshot(request);
   }
 
   /**
@@ -124,7 +124,7 @@ public void accessBikeRental() {
       .buildRequest();
 
     try {
-      expectArriveByToMatchDepartAtAndSnapshot(request);
+      expectRequestResponseToMatchSnapshot(request);
     } catch (CompletionException e) {
       RoutingValidationException.unwrapAndRethrowCompletionException(e);
     }
@@ -148,7 +148,7 @@ public void egressBikeRental() {
       .withTo(p1)
       .buildRequest();
 
-    expectArriveByToMatchDepartAtAndSnapshot(request);
+    expectRequestResponseToMatchSnapshot(request);
   }
 
   private void allowArrivalWithRentalVehicle(RouteRequestBuilder builder) {

application/src/test/java/org/opentripplanner/routing/algorithm/mapping/CarSnapshotTest.java

@@ -71,7 +71,7 @@ public void directCarPark() {
       .withTo(p2)
       .buildRequest();
 
-    expectArriveByToMatchDepartAtAndSnapshot(request);
+    expectRequestResponseToMatchSnapshot(request);
   }
 
   @DisplayName("Direct CAR_PICKUP (with walking both ends)")
@@ -118,6 +118,6 @@ public void directCarPickupWithoutWalking() {
       .withPreferences(pref -> pref.withWalk(w -> w.withSpeed(1.0)))
       .buildRequest();
 
-    expectArriveByToMatchDepartAtAndSnapshot(request);
+    expectRequestResponseToMatchSnapshot(request);
   }
 }

application/src/test/java/org/opentripplanner/routing/algorithm/mapping/ElevationSnapshotTest.java

@@ -84,7 +84,7 @@ public void directBikeRental() {
       .withTo(p2)
       .buildRequest();
 
-    expectArriveByToMatchDepartAtAndSnapshot(request);
+    expectRequestResponseToMatchSnapshot(request);
   }
 
   @DisplayName("Direct BIKE")
@@ -124,7 +124,7 @@ public void accessBikeRental() {
       .buildRequest();
 
     try {
-      expectArriveByToMatchDepartAtAndSnapshot(request);
+      expectRequestResponseToMatchSnapshot(request);
     } catch (CompletionException e) {
       RoutingValidationException.unwrapAndRethrowCompletionException(e);
     }
@@ -139,7 +139,7 @@ public void transit() {
       .withTo(p1)
       .buildRequest();
 
-    expectArriveByToMatchDepartAtAndSnapshot(request);
+    expectRequestResponseToMatchSnapshot(request);
   }
 
   @Override

application/src/test/java/org/opentripplanner/routing/algorithm/mapping/SnapshotTestBase.java

@@ -181,34 +181,6 @@ protected void expectRequestResponseToMatchSnapshot(RouteRequest request) {
     logDebugInformationOnFailure(request, () -> expectItinerariesToMatchSnapshot(itineraries));
   }
 
-  protected void expectArriveByToMatchDepartAtAndSnapshot(RouteRequest request) {
-    List<Itinerary> departByItineraries = retrieveItineraries(request);
-
-    logDebugInformationOnFailure(request, () -> assertFalse(departByItineraries.isEmpty()));
-
-    logDebugInformationOnFailure(request, () ->
-      expectItinerariesToMatchSnapshot(departByItineraries)
-    );
-
-    RouteRequest arriveBy = request
-      .copyOf()
-      .withArriveBy(true)
-      .withDateTime(departByItineraries.get(0).legs().getLast().endTime().toInstant())
-      .buildRequest();
-
-    List<Itinerary> arriveByItineraries = retrieveItineraries(arriveBy);
-
-    var departAtItinerary = departByItineraries.get(0);
-    var arriveByItinerary = arriveByItineraries.get(0);
-
-    logDebugInformationOnFailure(arriveBy, () ->
-      assertEquals(
-        asJsonString(itineraryMapper.mapItinerary(departAtItinerary)),
-        asJsonString(itineraryMapper.mapItinerary(arriveByItinerary))
-      )
-    );
-  }
-
   protected void expectItinerariesToMatchSnapshot(List<Itinerary> itineraries) {
     expect(itineraryMapper.mapItineraries(itineraries))
       .serializer(snapshotSerializer)

application/src/test/java/org/opentripplanner/routing/algorithm/mapping/TransitSnapshotTest.java

@@ -68,7 +68,7 @@ public void test_trip_planning_with_walk_only() {
       .withTo(p2)
       .buildRequest();
 
-    expectArriveByToMatchDepartAtAndSnapshot(request);
+    expectRequestResponseToMatchSnapshot(request);
   }
 
   @Test
@@ -82,7 +82,7 @@ public void test_trip_planning_with_walk_only_stop() {
       .withTo(p2)
       .buildRequest();
 
-    expectArriveByToMatchDepartAtAndSnapshot(request);
+    expectRequestResponseToMatchSnapshot(request);
   }
 
   @Test
@@ -121,7 +121,7 @@ public void test_trip_planning_with_transit_stop() {
       .withTo(p3)
       .buildRequest();
 
-    expectArriveByToMatchDepartAtAndSnapshot(request);
+    expectRequestResponseToMatchSnapshot(request);
   }
 
   @Test
@@ -133,6 +133,6 @@ public void test_trip_planning_with_transit_stop_collection() {
       .withTo(p3)
       .buildRequest();
 
-    expectArriveByToMatchDepartAtAndSnapshot(request);
+    expectRequestResponseToMatchSnapshot(request);
   }
 }