Skip to content

Commit 8a0b7c5

Browse files
committed
Document validation rule making Order and VisitNumber mutually exclusive
1 parent 87bbef1 commit 8a0b7c5

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

application/src/main/java/org/opentripplanner/updater/trip/siri/CallWrapper.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,9 @@ static Result<List<CallWrapper>, UpdateErrorType> of(
7171
}
7272
}
7373

74+
// we reject messages that contain both Order and VisitNumber since we do not see any obvious
75+
// use case that requires both, and making them mutually exclusive make the implementation
76+
// simpler. We can relax this validation rule later if valid use cases are identified.
7477
if (hasOrderCalls && hasVisitNumberCalls) {
7578
return Result.failure(UpdateErrorType.MIXED_CALL_ORDER_AND_VISIT_NUMBER);
7679
}

0 commit comments

Comments
 (0)