Add viaLocationType to Place in Transmodel API

Author: optionsome

application/src/main/java/org/opentripplanner/apis/transmodel/model/EnumTypes.java

@@ -7,6 +7,7 @@
 import java.util.function.Function;
 import org.opentripplanner.framework.doc.DocumentedEnum;
 import org.opentripplanner.model.plan.VertexType;
+import org.opentripplanner.model.plan.leg.ViaLocationType;
 import org.opentripplanner.model.plan.walkstep.AbsoluteDirection;
 import org.opentripplanner.model.plan.walkstep.RelativeDirection;
 import org.opentripplanner.model.transfer.TransferPriority;
@@ -463,6 +464,22 @@ public class EnumTypes {
     //TODO QL: .value("parkAndRide", VertexType.PARKANDRIDE)
     .build();
 
+  public static final GraphQLEnumType VIA_LOCATION_TYPE = GraphQLEnumType.newEnum()
+    .name("ViaLocationType")
+    .value(
+      "passThrough",
+      ViaLocationType.PASS_THROUGH,
+      "Stop location must be " +
+      "visited on-board a transit vehicle or the journey must alight or board at the location."
+    )
+    .value(
+      "visit",
+      ViaLocationType.VISIT,
+      "Location is a stop location where the " +
+      "passenger boards a vehicle or alights from a vehicle, or a coordinate which is visited."
+    )
+    .build();
+
   public static final GraphQLEnumType WHEELCHAIR_BOARDING = GraphQLEnumType.newEnum()
     .name("WheelchairBoarding")
     .value(

application/src/main/java/org/opentripplanner/apis/transmodel/model/plan/PlanPlaceType.java

@@ -131,6 +131,17 @@ public static GraphQLObjectType create(
           )
           .build()
       )
+      .field(
+        GraphQLFieldDefinition.newFieldDefinition()
+          .name("viaLocationType")
+          .type(EnumTypes.VIA_LOCATION_TYPE)
+          .description(
+            "If this place was used as a via location in the request, this defines " +
+            "what type of a via location this place is."
+          )
+          .dataFetcher(environment -> ((Place) environment.getSource()).viaLocationType)
+          .build()
+      )
       //                .field(GraphQLFieldDefinition.newFieldDefinition()
       //                        .name("bikePark")
       //                        .type(bikeParkType)

application/src/main/resources/org/opentripplanner/apis/transmodel/schema.graphql

@@ -527,6 +527,8 @@ type Place {
   rentalVehicle: RentalVehicle
   "Type of vertex. (Normal, Bike sharing station, Bike P+R, Transit quay) Mostly used for better localization of bike sharing and P+R station names"
   vertexType: VertexType
+  "If this place was used as a via location in the request, this defines what type of a via location this place is."
+  viaLocationType: ViaLocationType
 }
 
 type PlaceAtDistance {
@@ -2079,6 +2081,13 @@ enum VertexType {
   transit
 }
 
+enum ViaLocationType {
+  "Stop location must be visited on-board a transit vehicle or the journey must alight or board at the location."
+  passThrough
+  "Location is a stop location where the passenger boards a vehicle or alights from a vehicle, or a coordinate which is visited."
+  visit
+}
+
 enum WheelchairBoarding {
   "There is no accessibility information for the stopPlace/quay."
   noInformation