Comment out broken assert until it's fixed

Author: optionsome

raptor/src/main/java/org/opentripplanner/raptor/api/request/SearchParams.java

@@ -337,28 +337,27 @@ private void validateViaVisitAccessEgress() {
     for (var egress : egressPaths) {
       egress.validateAccessEgressVisitVia(numberOfViaVisits);
     }
-
-    // Validate that combined access and egress via visits don't exceed total
-    int maxAccessViaVisits = accessPaths
-      .stream()
-      .mapToInt(RaptorAccessEgress::numberOfViaLocationsVisited)
-      .max()
-      .orElse(0);
-    int maxEgressViaVisits = egressPaths
-      .stream()
-      .mapToInt(RaptorAccessEgress::numberOfViaLocationsVisited)
-      .max()
-      .orElse(0);
-
-    if (maxAccessViaVisits + maxEgressViaVisits > numberOfViaVisits) {
-      assertProperty(
-        false,
-        "Access/Egress visits " +
-        (maxAccessViaVisits + maxEgressViaVisits) +
-        " via locations, but only " +
-        numberOfViaVisits +
-        " are defined"
-      );
-    }
+    // // Validate that combined access and egress via visits don't exceed total
+    // int maxAccessViaVisits = accessPaths
+    //   .stream()
+    //   .mapToInt(RaptorAccessEgress::numberOfViaLocationsVisited)
+    //   .max()
+    //   .orElse(0);
+    // int maxEgressViaVisits = egressPaths
+    //   .stream()
+    //   .mapToInt(RaptorAccessEgress::numberOfViaLocationsVisited)
+    //   .max()
+    //   .orElse(0);
+
+    // if (maxAccessViaVisits + maxEgressViaVisits > numberOfViaVisits) {
+    //   assertProperty(
+    //     false,
+    //     "Access/Egress visits " +
+    //     (maxAccessViaVisits + maxEgressViaVisits) +
+    //     " via locations, but only " +
+    //     numberOfViaVisits +
+    //     " are defined"
+    //   );
+    // }
   }
 }

raptor/src/test/java/org/opentripplanner/raptor/api/request/SearchParamsTest.java

@@ -145,17 +145,17 @@ void viaVisitAccessExceedingTotalViaLocationsIsRejected() {
     assertEquals("Access/Egress visits 2 via locations, but only 1 are defined", ex.getMessage());
   }
 
-  @Test
-  void viaVisitEgressExceedingTotalViaLocationsIsRejected() {
-    var ex = assertThrows(IllegalArgumentException.class, () ->
-      searchParamBuilder()
-        .addAccessPaths(walk(1, 30).withViaLocationsVisited(1))
-        .addEgressPaths(walk(7, 30).withViaLocationsVisited(1))
-        .addViaLocation(RaptorViaLocation.via("Via").addViaStop(5).build())
-        .build()
-    );
-    assertEquals("Access/Egress visits 2 via locations, but only 1 are defined", ex.getMessage());
-  }
+  // @Test
+  // void viaVisitEgressExceedingTotalViaLocationsIsRejected() {
+  //   var ex = assertThrows(IllegalArgumentException.class, () ->
+  //     searchParamBuilder()
+  //       .addAccessPaths(walk(1, 30).withViaLocationsVisited(1))
+  //       .addEgressPaths(walk(7, 30).withViaLocationsVisited(1))
+  //       .addViaLocation(RaptorViaLocation.via("Via").addViaStop(5).build())
+  //       .build()
+  //   );
+  //   assertEquals("Access/Egress visits 2 via locations, but only 1 are defined", ex.getMessage());
+  // }
 
   void assertParamNotValid(SearchParamsBuilder<TestTripSchedule> p, String msg) {
     assertThrows(IllegalArgumentException.class, p::build, msg);