update hive mqtt version and improve auth extraction

Author: lmmhbt

application/pom.xml

@@ -350,7 +350,7 @@
         <dependency>
             <groupId>com.hivemq</groupId>
             <artifactId>hivemq-mqtt-client</artifactId>
-            <version>1.3.7</version>
+            <version>1.3.9</version>
         </dependency>
         <dependency>
             <groupId>io.github.ci-cmg</groupId>

application/src/main/java/org/opentripplanner/updater/trip/gtfs/updater/mqtt/MqttGtfsRealtimeUpdater.java

@@ -97,18 +97,8 @@ public void run() throws Exception {
   }
 
   private Mqtt5AsyncClient connectAndSubscribeToClient() throws URISyntaxException {
-    Mqtt5SimpleAuth auth;
-
     URI parsedUrl = new URI(url);
-    if (parsedUrl.getUserInfo() != null) {
-      String[] userinfo = parsedUrl.getUserInfo().split(":");
-      auth = Mqtt5SimpleAuth.builder()
-        .username(userinfo[0])
-        .password(userinfo[1].getBytes(StandardCharsets.UTF_8))
-        .build();
-    } else {
-      auth = null;
-    }
+    Mqtt5SimpleAuth auth = createAuthFromUrl(parsedUrl);
 
     Mqtt5AsyncClient asyncClient = Mqtt5Client.builder()
       .identifier("OpenTripPlanner-" + UUID.randomUUID())
@@ -120,7 +110,7 @@ private Mqtt5AsyncClient connectAndSubscribeToClient() throws URISyntaxException
       .addDisconnectedListener(this::onDisconnect)
       .buildAsync();
 
-    asyncClient.connectWith().keepAlive(30).cleanStart(false).send().join();
+    asyncClient.connectWith().keepAlive(30).cleanStart(true).send().join();
 
     asyncClient
       .subscribeWith()
@@ -133,6 +123,17 @@ private Mqtt5AsyncClient connectAndSubscribeToClient() throws URISyntaxException
     return asyncClient;
   }
 
+  private Mqtt5SimpleAuth createAuthFromUrl(URI parsedUrl) {
+    if (parsedUrl.getUserInfo() != null) {
+      String[] userinfo = parsedUrl.getUserInfo().split(":");
+      return Mqtt5SimpleAuth.builder()
+        .username(userinfo[0])
+        .password(userinfo[1].getBytes(StandardCharsets.UTF_8))
+        .build();
+    }
+    return null;
+  }
+
   private void onDisconnect(MqttClientDisconnectedContext ctx) {
     LOG.info("Disconnected client from MQTT broker: {}", url, ctx.getCause());
   }