Make totalCount required

Author: optionsome

application/src/main/java/org/opentripplanner/framework/graphql/CountedConnection.java

@@ -1,7 +1,6 @@
 package org.opentripplanner.framework.graphql;
 
 import graphql.relay.Connection;
-import javax.annotation.Nullable;
 
 /**
  * This interface extends the standard GraphQL Connection interface with a method to get the total
@@ -11,6 +10,5 @@ public interface CountedConnection<T> extends Connection<T> {
   /**
    * The total number of items available in the underlying collection
    */
-  @Nullable
-  Integer getTotalCount();
+  int getTotalCount();
 }

application/src/main/java/org/opentripplanner/framework/graphql/DefaultCountedConnection.java

@@ -5,7 +5,6 @@
 import graphql.relay.PageInfo;
 import java.util.List;
 import java.util.Objects;
-import javax.annotation.Nullable;
 import org.opentripplanner.utils.tostring.ToStringBuilder;
 
 /**
@@ -24,8 +23,7 @@ public DefaultCountedConnection(List<Edge<T>> edges, PageInfo pageInfo, Integer
   }
 
   @Override
-  @Nullable
-  public Integer getTotalCount() {
+  public int getTotalCount() {
     return totalCount;
   }
 

application/src/main/resources/org/opentripplanner/apis/gtfs/schema.graphqls

@@ -2706,7 +2706,7 @@ type TripOnServiceDateConnection {
   pages). Note, this number might not stay the same throughout the paging as trips might be added or
   removed.
   """
-  totalCount: Int
+  totalCount: Int!
 }
 
 """