Skip to content

Commit 2120dce

Browse files
authored
Merge pull request #5697 from HSLdevcom/AB#489
AB#489 Fix search value resetting on location update
2 parents 9abe563 + eda6cee commit 2120dce

6 files changed

Lines changed: 16 additions & 10 deletions

File tree

digitransit-component/packages/digitransit-component-autosuggest-panel/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@digitransit-component/digitransit-component-autosuggest-panel",
3-
"version": "8.2.1",
3+
"version": "8.2.2",
44
"description": "digitransit-component autosuggest-panel module",
55
"main": "index.js",
66
"files": [

digitransit-component/packages/digitransit-component-autosuggest/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@digitransit-component/digitransit-component-autosuggest",
3-
"version": "7.1.2",
3+
"version": "7.1.3",
44
"description": "digitransit-component autosuggest module",
55
"main": "index.js",
66
"files": [

digitransit-component/packages/digitransit-component-autosuggest/src/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,8 @@ function DTAutosuggest({
281281
};
282282
const [state, dispatch] = useReducer(searchReducer, initialState);
283283
// Reset the state when value or sources change, this also triggers a new search
284-
useEffect(() => dispatch({ type: 'RESET', initialState }), [value, sources]);
284+
useEffect(() => dispatch({ type: 'RESET', initialState }), [value]);
285+
useEffect(() => dispatch({ type: 'RESET_SOURCES', sources }), [sources]);
285286
// create and store input ref in the parent if storeRef is provided
286287
const inputRef = useRef(id);
287288
useEffect(() => {

digitransit-component/packages/digitransit-component-autosuggest/src/utils/searchReducer.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ export const searchReducer = (state, action) => {
1616
...state,
1717
suggestions: [],
1818
};
19+
case 'RESET_SOURCES':
20+
return {
21+
...state,
22+
sources: action.sources,
23+
};
1924
case 'SET_SOURCES':
2025
return {
2126
...state,

digitransit-component/packages/digitransit-component/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@digitransit-component/digitransit-component",
3-
"version": "5.0.5",
3+
"version": "5.0.6",
44
"description": "a JavaScript library for Digitransit",
55
"main": "digitransit-component",
66
"module": "digitransit-component.mjs",
@@ -18,8 +18,8 @@
1818
"url": "git://github.com/HSLdevcom/digitransit-ui.git"
1919
},
2020
"dependencies": {
21-
"@digitransit-component/digitransit-component-autosuggest": "^7.1.2",
22-
"@digitransit-component/digitransit-component-autosuggest-panel": "^8.2.1",
21+
"@digitransit-component/digitransit-component-autosuggest": "^7.1.3",
22+
"@digitransit-component/digitransit-component-autosuggest-panel": "^8.2.2",
2323
"@digitransit-component/digitransit-component-control-panel": "^7.1.1",
2424
"@digitransit-component/digitransit-component-favourite-bar": "^5.0.2",
2525
"@digitransit-component/digitransit-component-favourite-editing-modal": "^5.0.2",

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2061,7 +2061,7 @@ __metadata:
20612061
languageName: unknown
20622062
linkType: soft
20632063

2064-
"@digitransit-component/digitransit-component-autosuggest-panel@npm:^8.2.1, @digitransit-component/digitransit-component-autosuggest-panel@workspace:digitransit-component/packages/digitransit-component-autosuggest-panel":
2064+
"@digitransit-component/digitransit-component-autosuggest-panel@npm:^8.2.2, @digitransit-component/digitransit-component-autosuggest-panel@workspace:digitransit-component/packages/digitransit-component-autosuggest-panel":
20652065
version: 0.0.0-use.local
20662066
resolution: "@digitransit-component/digitransit-component-autosuggest-panel@workspace:digitransit-component/packages/digitransit-component-autosuggest-panel"
20672067
peerDependencies:
@@ -2080,7 +2080,7 @@ __metadata:
20802080
languageName: unknown
20812081
linkType: soft
20822082

2083-
"@digitransit-component/digitransit-component-autosuggest@npm:^7.1.2, @digitransit-component/digitransit-component-autosuggest@workspace:digitransit-component/packages/digitransit-component-autosuggest":
2083+
"@digitransit-component/digitransit-component-autosuggest@npm:^7.1.3, @digitransit-component/digitransit-component-autosuggest@workspace:digitransit-component/packages/digitransit-component-autosuggest":
20842084
version: 0.0.0-use.local
20852085
resolution: "@digitransit-component/digitransit-component-autosuggest@workspace:digitransit-component/packages/digitransit-component-autosuggest"
20862086
dependencies:
@@ -2262,8 +2262,8 @@ __metadata:
22622262
version: 0.0.0-use.local
22632263
resolution: "@digitransit-component/digitransit-component@workspace:digitransit-component/packages/digitransit-component"
22642264
dependencies:
2265-
"@digitransit-component/digitransit-component-autosuggest": "npm:^7.1.2"
2266-
"@digitransit-component/digitransit-component-autosuggest-panel": "npm:^8.2.1"
2265+
"@digitransit-component/digitransit-component-autosuggest": "npm:^7.1.3"
2266+
"@digitransit-component/digitransit-component-autosuggest-panel": "npm:^8.2.2"
22672267
"@digitransit-component/digitransit-component-control-panel": "npm:^7.1.1"
22682268
"@digitransit-component/digitransit-component-favourite-bar": "npm:^5.0.2"
22692269
"@digitransit-component/digitransit-component-favourite-editing-modal": "npm:^5.0.2"

0 commit comments

Comments
 (0)