Fix flashing suggestion in digitransit-component-autosuggest.

Author: VillePihlava

digitransit-component/packages/digitransit-component-autosuggest-panel/package.json

@@ -28,7 +28,7 @@
   "author": "Digitransit Authors",
   "license": "(AGPL-3.0 OR EUPL-1.2)",
   "peerDependencies": {
-    "@digitransit-component/digitransit-component-autosuggest": "^7.1.10",
+    "@digitransit-component/digitransit-component-autosuggest": "^7.1.11",
     "@digitransit-component/digitransit-component-icon": "^2.0.2",
     "@hsl-fi/sass": "1.0.0",
     "classnames": "2.5.1",

digitransit-component/packages/digitransit-component-autosuggest/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@digitransit-component/digitransit-component-autosuggest",
-  "version": "7.1.10",
+  "version": "7.1.11",
   "description": "digitransit-component autosuggest module",
   "main": "index.js",
   "files": [

digitransit-component/packages/digitransit-component-autosuggest/src/index.js

@@ -522,9 +522,15 @@ function DTAutosuggest({
     openMenu();
   };
 
-  // Fetch suggestions when isOpen, value, or fetchSuggestions dependies change
+  // Fetch suggestions when isOpen, value, or fetchSuggestions dependencies change
   useEffect(() => {
-    if (isOpen || state.renderMobile) {
+    // Don't search when the search field (state.value) contains position strings that were given as a prop (value),
+    // because they are UI labels not real search terms. Fetching suggestions with them caused a quickly flashing set of
+    // irrelevant results, e.g. 'Käytä nykyistä sijaintia' -> 'City-käytävä'.
+    if (
+      (isOpen || state.renderMobile) &&
+      !(state.value === value && positions.includes(value))
+    ) {
       fetchSuggestions(state.value);
     }
   }, [isOpen, state.renderMobile, state.value, fetchSuggestions]);

digitransit-component/packages/digitransit-component/package.json

@@ -18,7 +18,7 @@
     "url": "git://github.com/HSLdevcom/digitransit-ui.git"
   },
   "dependencies": {
-    "@digitransit-component/digitransit-component-autosuggest": "^7.1.10",
+    "@digitransit-component/digitransit-component-autosuggest": "^7.1.11",
     "@digitransit-component/digitransit-component-autosuggest-panel": "^8.3.5",
     "@digitransit-component/digitransit-component-control-panel": "^7.1.3",
     "@digitransit-component/digitransit-component-favourite-bar": "^5.0.5",