Skip to content

Ab#593: Static files configuration #5848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Antiik91 wants to merge 2 commits into
base: v3
Choose a base branch
from
+3 −13
Open

Ab#593: Static files configuration #5848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
831c042
TODO
Antiik91 Jun 5, 2026
76e31b5
default static files env
Antiik91 Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/component/AppBarHsl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ const AppBarHsl = ({ lang, user, favourites }, context) => {
{!config.hideHeader && (
<SiteHeader
baseUrl={config.URL.ROOTLINK}
staticAssetsUrl="/static-assets"
staticAssetsUrl={config.URL.STATIC_ASSETS}
lang={lang}
userMenu={userMenu}
langMenu={languages}
Expand Down
3 changes: 2 additions & 1 deletion app/configurations/config.hsl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ const SUGGESTION_URL = process.env.CONTENT_DOMAIN
? `${process.env.CONTENT_DOMAIN}/api/v1/search/suggestions`
: 'https://content.hsl.fi/api/v1/search/suggestions'; // old url
const travelersAccountUrl = process.env.TRAVELERS_ACCOUNT_URL;
const staticAssetsUrl = process.env.STATIC_ASSETS_URL;
const staticAssetsUrl =
process.env.STATIC_ASSETS_URL || 'https://staticfiles-test.hslfi.hsldev.com/';

const virtualMonitorBaseUrl = IS_DEV
? 'https://dev-hslmonitori.digitransit.fi'
Expand Down
11 changes: 0 additions & 11 deletions server/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,17 +123,6 @@ function setUpMiddleware() {
// proxy for dev-bundle
app.use('/proxy/', proxy(`http://localhost:${hotloadPort}/`));
}
// Proxy static assets to avoid CORS issues when fetching from the browser
// TODO this is a hacky solution, contact site-header admins to update site-header cors settings.
const staticAssetsBaseUrl = process.env.STATIC_ASSETS_URL;
if (staticAssetsBaseUrl) {
app.use(
'/static-assets',
proxy(staticAssetsBaseUrl, {
proxyReqPathResolver: req => req.url,
}),
);
}
}

function onError(err, req, res) {
Expand Down
Loading