Skip to content

AB#598 - Fix flashing suggestion in digitransit-component-autosuggest #5849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
VillePihlava wants to merge 1 commit into
base: v3
Choose a base branch
from
+11 −5
Draft

AB#598 - Fix flashing suggestion in digitransit-component-autosuggest #5849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion digitransit-component/packages/digitransit-component-autosuggest-panel/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"author": "Digitransit Authors",
"license": "(AGPL-3.0 OR EUPL-1.2)",
"peerDependencies": {
"@digitransit-component/digitransit-component-autosuggest": "^7.1.10",
"@digitransit-component/digitransit-component-autosuggest": "^7.1.11",
"@digitransit-component/digitransit-component-icon": "^2.0.2",
"@hsl-fi/sass": "1.0.0",
"classnames": "2.5.1",
Expand Down
2 changes: 1 addition & 1 deletion digitransit-component/packages/digitransit-component-autosuggest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@digitransit-component/digitransit-component-autosuggest",
"version": "7.1.10",
"version": "7.1.11",
"description": "digitransit-component autosuggest module",
"main": "index.js",
"files": [
Expand Down
10 changes: 8 additions & 2 deletions digitransit-component/packages/digitransit-component-autosuggest/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,9 +522,15 @@ function DTAutosuggest({
openMenu();
};

// Fetch suggestions when isOpen, value, or fetchSuggestions dependies change
// Fetch suggestions when isOpen, value, or fetchSuggestions dependencies change
useEffect(() => {
if (isOpen || state.renderMobile) {
// Don't search when the search field (state.value) contains position strings that were given as a prop (value),
// because they are UI labels not real search terms. Fetching suggestions with them caused a quickly flashing set of
// irrelevant results, e.g. 'Käytä nykyistä sijaintia' -> 'City-käytävä'.
if (
(isOpen || state.renderMobile) &&
!(state.value === value && positions.includes(value))
) {
fetchSuggestions(state.value);
}
}, [isOpen, state.renderMobile, state.value, fetchSuggestions]);
Expand Down
2 changes: 1 addition & 1 deletion digitransit-component/packages/digitransit-component/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"url": "git://github.com/HSLdevcom/digitransit-ui.git"
},
"dependencies": {
"@digitransit-component/digitransit-component-autosuggest": "^7.1.10",
"@digitransit-component/digitransit-component-autosuggest": "^7.1.11",
"@digitransit-component/digitransit-component-autosuggest-panel": "^8.3.5",
"@digitransit-component/digitransit-component-control-panel": "^7.1.3",
"@digitransit-component/digitransit-component-favourite-bar": "^5.0.5",
Expand Down
Loading