Merge pull request #159 from HSLdevcom/68397-dependency-upgrades

dependecy updates, webpack configuration updates

Author: ahjyrkia

.babelrc

@@ -1,10 +1,12 @@
 module.exports = {
+    parser: "@babel/eslint-parser",
     parserOptions: {
-        ecmaVersion: 2018,
-        ecmaFeatures: {
-            jsx: true
-        }
+       requireConfigFile: false,
+        babelOptions: {
+            presets: ["@babel/preset-env"],
+        },
     },
+
     extends: ["airbnb", "plugin:prettier/recommended"],
     rules: {
         "no-console": "off",

.eslintrc.js

@@ -0,0 +1,14 @@
+name: 'Dependency scan'
+on: [pull_request]
+permissions:
+  contents: read
+jobs:
+  dependency-review:
+    runs-on: ubuntu-latest
+    steps:
+      - name: 'Checkout Repository'
+        uses: actions/checkout@v4
+      - name: 'Dependency Review'
+        uses: actions/dependency-review-action@v4
+        with:
+          fail-on-severity: high

.github/workflows/dependency_scan.yml

@@ -10,13 +10,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
       - name: Cypress run
         uses: cypress-io/github-action@v4
-        with:
-          config-file: /cypress.dev.json
         env:
           CYPRESS_BASE_URL: https://dev.kartat.hsl.fi/kartta
+          CYPRESS_API_URL: https://dev.kartat.hsl.fi/routemap-api
           CYPRESS_HSLID_CLIENT_ID: ${{ secrets.CYPRESS_HSLID_CLIENT_ID }}
           CYPRESS_HSLID_CLIENT_SECRET: ${{ secrets.CYPRESS_HSLID_CLIENT_SECRET }}
           CYPRESS_TESTING_HSLID_USERNAME: ${{ secrets.CYPRESS_TESTING_HSLID_USERNAME }}

.github/workflows/dev.yml

@@ -0,0 +1,6 @@
+{
+  "presets": [
+    ["@babel/preset-env"],
+    ["@babel/preset-react", { "runtime": "automatic" }]
+  ]
+}

babel.config.json

@@ -0,0 +1,17 @@
+const { defineConfig } = require("cypress");
+
+module.exports = defineConfig({
+  viewportWidth: 1200,
+  viewportHeight: 1300,
+  numTestsKeptInMemory: 1,
+  projectId: "rax4es",
+  video: true,
+  e2e: {
+    specPattern: "cypress/integration/**/*.spec.js",
+    supportFile: "cypress/support/index.js",
+    baseUrl: process.env.CYPRESS_BASE_URL || "http://localhost:3000",
+    env: {
+      apiUrl: process.env.CYPRESS_API_URL || "http://localhost:4000",
+    },
+  },
+});

cypress.config.js

@@ -1,7 +1,7 @@
-const uuidv4 = require("uuid/v4");
+const { v4: uuidv4 } = require("uuid");
 
 // TODO: Envify here and cypress.json properly
-const API_URL = Cypress.config().apiUrl;
+const API_URL = Cypress.env("API_URL");
 const TEST_PREFIX = "CY-TEST";
 
 describe("Basic functionalities", () => {
@@ -34,8 +34,7 @@ describe("Basic functionalities", () => {
 
     it("Add list, select it for use and show it", () => {
         const uuid = `${TEST_PREFIX}-${uuidv4()}`;
-        cy.server();
-        cy.route("POST", `${API_URL}/builds`).as("postBuild");
+        cy.intercept("POST", `${API_URL}/builds`).as("postBuild");
 
         cy.get("[data-cy=toggle-mode-button]").click();
         cy.get("[data-cy=new-list-button").click();
@@ -153,14 +152,12 @@ describe("Basic functionalities", () => {
     it("Generate poster", () => {
         const uuid = `${TEST_PREFIX}-${uuidv4()}`;
         const posterName = uuid.substr(0, 5);
-        cy.server();
-        cy.route("POST", `${API_URL}/builds`).as("postBuild");
+
+        cy.intercept("POST", `${API_URL}/builds`).as("postBuild");
 
         cy.get("[data-cy=toggle-mode-button]").click();
-        cy.get("[data-cy=new-list-button").click();
-        cy.get("[data-cy=new-list-name-input]")
-            .click()
-            .type(uuid);
+        cy.get("[data-cy=new-list-button]").click();
+        cy.get("[data-cy=new-list-name-input]").click().type(uuid);
 
         cy.get("[data-cy=new-list-name-input]").should("have.value", uuid);
         cy.get("[data-cy=add-list-button]").click();
@@ -170,33 +167,25 @@ describe("Basic functionalities", () => {
         cy.get("[data-cy=select-list-button]").click();
 
         cy.get("[data-cy=size-selector-button]").click();
-        cy.get("[data-cy=size-selector-width-input]")
-            .click()
-            .clear()
-            .type(200);
-        cy.get("[data-cy=size-selector-height-input]")
-            .click()
-            .clear()
-            .type(200);
+        cy.get("[data-cy=size-selector-width-input]").click().clear().type(200);
+        cy.get("[data-cy=size-selector-height-input]").click().clear().type(200);
 
         cy.get("[data-cy=new-poster-name]").type(posterName);
-        cy.get("[data-cy=generate-button").click();
-        cy.get("[data-cy=close-generate-prompt-button").click();
+        cy.get("[data-cy=generate-button]").click();
+        cy.get("[data-cy=close-generate-prompt-button]").click();
         cy.get("[data-cy=show-list-button]").click();
 
-        // 60 seconds should be more than enough for 200x200 poster.
-        // Better implementation would be to somehow stop waiting after
-        // polling for build status returns "pending: 0".
         cy.wait(60000);
         cy.get(`[data-cy=${posterName}]`).contains("READY");
 
-        // Remove build
         cy.request("GET", `${API_URL}/builds`)
             .its("body")
             .then((buildArr) => {
-                const build = buildArr.find((build) => build.title === uuid);
-                cy.request("DELETE", `${API_URL}/builds/${build.id}`);
-            });
+                const build = buildArr.find((b) => b.title === uuid);
+                if (build) {
+                    cy.request("DELETE", `${API_URL}/builds/${build.id}`);
+                }
+        });
 
         cy.get("[data-cy=close-list-modal-button]").click();
     });

cypress.dev.json

@@ -3,10 +3,14 @@ Cypress.Commands.add("hslLogin", () => {
     const AUTH_SCOPE =
         "email https://oneportal.trivore.com/scope/groups.readonly";
 
-    const CLIENT_ID = Cypress.env("CYPRESS_HSLID_CLIENT_ID");
-    const CLIENT_SECRET = Cypress.env("CYPRESS_HSLID_CLIENT_SECRET");
-    const HSLID_USERNAME = Cypress.env("CYPRESS_TESTING_HSLID_USERNAME");
-    const HSLID_PASSWORD = Cypress.env("CYPRESS_TESTING_HSLID_PASSWORD");
+    const CLIENT_ID = Cypress.env("HSLID_CLIENT_ID");
+    const CLIENT_SECRET = Cypress.env("HSLID_CLIENT_SECRET");
+    const HSLID_USERNAME = Cypress.env("TESTING_HSLID_USERNAME");
+    const HSLID_PASSWORD = Cypress.env("TESTING_HSLID_PASSWORD");
+
+    if (!CLIENT_ID || !CLIENT_SECRET) {
+        throw new Error("Missing HSLID envs");
+    }
 
     const authHeader = `Basic ${btoa(`${CLIENT_ID}:${CLIENT_SECRET}`)}`;
 
@@ -26,7 +30,10 @@ Cypress.Commands.add("hslLogin", () => {
         }
     };
 
-    cy.request(options).then((response) => {
+    cy.request({ ...options, failOnStatusCode: false }).then((response) => {
+        if (response.status !== 200) {
+            throw new Error(`Auth failed: ${response.status} ${JSON.stringify(response.body)}`);
+        }
         const {access_token} = response.body;
         cy.log(access_token);
         expect(response.status).to.eq(200);