Skip to content

Commit c8f583b

Browse files
committed
Update tests to use only "admin" role
1 parent 8adf826 commit c8f583b

3 files changed

Lines changed: 7 additions & 14 deletions

File tree

src/integration-test/kotlin/fi/hsl/jore4/auth/Constants.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -195,16 +195,14 @@ object Constants {
195195
"""
196196

197197
const val RO_USER_EXT_PERMISSION_ID = "0123456789ABCDE"
198-
const val RO_USER_EXT_PERMISSION_EXT_ID = "read-only"
198+
const val RO_USER_EXT_PERMISSION_EXT_ID = "admin"
199199
const val RO_USER_SUB = "60643ec68823e65ee44a9050"
200200
const val RO_USER_FIRST_NAME = "Rita"
201201
const val RO_USER_LAST_NAME = "Readonly"
202202
const val RO_USER_FULL_NAME = "$RO_USER_FIRST_NAME Roswita $RO_USER_LAST_NAME"
203203

204204
const val RW_USER_EXT_PERMISSION_1_ID = "123456789ABCDEFGH"
205-
const val RW_USER_EXT_PERMISSION_1_EXT_ID = "RO"
206-
const val RW_USER_EXT_PERMISSION_2_ID = "23456789ABCDEFGHIJ"
207-
const val RW_USER_EXT_PERMISSION_2_EXT_ID = "read-and-write"
205+
const val RW_USER_EXT_PERMISSION_1_EXT_ID = "admin"
208206
const val RW_USER_SUB = "13643ec68823e65ee4479432"
209207
const val RW_USER_FIRST_NAME = "Alicia"
210208
const val RW_USER_LAST_NAME = "Admin"

src/integration-test/kotlin/fi/hsl/jore4/auth/apipublic/v1/HasuraApiControllerTest.kt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@ class HasuraApiControllerTest(
3838
)
3939
private val rwUserInfoContent = MockOIDCProvider.createUserInfoResponseContent(
4040
Constants.RW_USER_SUB, Constants.RW_USER_FIRST_NAME, Constants.RW_USER_LAST_NAME, Constants.RW_USER_FULL_NAME,
41-
Pair(Constants.RW_USER_EXT_PERMISSION_1_ID, Constants.RW_USER_EXT_PERMISSION_1_EXT_ID),
42-
Pair(Constants.RW_USER_EXT_PERMISSION_2_ID, Constants.RW_USER_EXT_PERMISSION_2_EXT_ID)
41+
Pair(Constants.RW_USER_EXT_PERMISSION_1_ID, Constants.RW_USER_EXT_PERMISSION_1_EXT_ID)
4342
)
4443

4544
@BeforeEach
@@ -130,10 +129,10 @@ class HasuraApiControllerTest(
130129
UserTokenSet(BearerAccessToken(accessToken), RefreshToken(Constants.OIDC_REFRESH_TOKEN))
131130
)
132131

133-
requestBuilder.webhook(session, Constants.RW_USER_EXT_PERMISSION_2_EXT_ID)
132+
requestBuilder.webhook(session, Constants.RW_USER_EXT_PERMISSION_1_EXT_ID)
134133
.andExpect(status().isOk)
135134
.andExpect(jsonPath("$.X-Hasura-User-Id").value(Constants.RW_USER_SUB))
136-
.andExpect(jsonPath("$.X-Hasura-Role").value(Constants.RW_USER_EXT_PERMISSION_2_EXT_ID))
135+
.andExpect(jsonPath("$.X-Hasura-Role").value(Constants.RW_USER_EXT_PERMISSION_1_EXT_ID))
137136
.andExpect(jsonPath("$.Cache-Control").value(HasuraAuthService.CACHE_CONTROL_SPEC))
138137
}
139138
}

src/integration-test/kotlin/fi/hsl/jore4/auth/apipublic/v1/UserInfoApiControllerTest.kt

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ import fi.hsl.jore4.auth.Constants.RO_USER_LAST_NAME
2424
import fi.hsl.jore4.auth.Constants.RO_USER_SUB
2525
import fi.hsl.jore4.auth.Constants.RW_USER_EXT_PERMISSION_1_EXT_ID
2626
import fi.hsl.jore4.auth.Constants.RW_USER_EXT_PERMISSION_1_ID
27-
import fi.hsl.jore4.auth.Constants.RW_USER_EXT_PERMISSION_2_EXT_ID
28-
import fi.hsl.jore4.auth.Constants.RW_USER_EXT_PERMISSION_2_ID
2927
import fi.hsl.jore4.auth.Constants.RW_USER_FIRST_NAME
3028
import fi.hsl.jore4.auth.Constants.RW_USER_FULL_NAME
3129
import fi.hsl.jore4.auth.Constants.RW_USER_LAST_NAME
@@ -339,8 +337,7 @@ class UserInfoApiControllerTest(
339337
val newAccessToken = createJwtAccessToken()
340338
val userInfoContent = MockOIDCProvider.createUserInfoResponseContent(
341339
RW_USER_SUB, RW_USER_FIRST_NAME, RW_USER_LAST_NAME, RW_USER_FULL_NAME,
342-
Pair(RW_USER_EXT_PERMISSION_1_ID, RW_USER_EXT_PERMISSION_1_EXT_ID),
343-
Pair(RW_USER_EXT_PERMISSION_2_ID, RW_USER_EXT_PERMISSION_2_EXT_ID)
340+
Pair(RW_USER_EXT_PERMISSION_1_ID, RW_USER_EXT_PERMISSION_1_EXT_ID)
344341
)
345342

346343
with(MockOIDCProvider) {
@@ -361,9 +358,8 @@ class UserInfoApiControllerTest(
361358
.andExpect(jsonPath("$.fullName").value(RW_USER_FULL_NAME))
362359
.andExpect(jsonPath("$.givenName").value(RW_USER_FIRST_NAME))
363360
.andExpect(jsonPath("$.familyName").value(RW_USER_LAST_NAME))
364-
.andExpect(jsonPath("$.permissions.length()").value(2))
361+
.andExpect(jsonPath("$.permissions.length()").value(1))
365362
.andExpect(jsonPath("$.permissions[0]").value(RW_USER_EXT_PERMISSION_1_EXT_ID))
366-
.andExpect(jsonPath("$.permissions[1]").value(RW_USER_EXT_PERMISSION_2_EXT_ID))
367363
}
368364
}
369365
}

0 commit comments

Comments
 (0)