@Huulivoide reviewed 1 file and made 1 comment.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on jannebe).

.github/workflows/shared-run-e2e.yml line 286 at r1 (raw file):

      - name: Collect Docker container logs
        id: collect_docker_logs
        if: always() && steps.run_tests.outcome == 'failure'

Mää laittasin ihan vaan suoraan aina, vaikka testit onnistuiskin. Ei tarvi sitten koskaan lähtä muutteleen, jos vaikka jostain tarviikin, tai vaikka haluu esim verrata onnistuneen ajon lokeja epäonnistuneeseen.

@culka reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on jannebe).

.github/workflows/shared-run-e2e.yml line 311 at r3 (raw file):

          if [[ "${test_server_logs_exist}" == "true" ]]
          then
            find ${{ github.workspace }}/docker-logs -type f

Hetken ihmettelin mikä tämä on, mutta ilmeisesti tulostetaan lokiin vain mille palveluille on lokit? Jos haluaa, niin echo "Logs for services:" maininta aiemmin ei haittaisi.

@Huulivoide reviewed 2 files and all commit messages, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on jannebe).