Skip to content

Commit cfea3bd

Browse files
committed
Reacy: Fix improper/missing key props
- ExternalLinks: Fix key prop to use proper id in edit form. - StopsByLineSearchGroupedStopsResults: Add missing key prop.
1 parent 17d66bd commit cfea3bd

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

ui/src/components/stop-registry/components/ExternalLinks/ExternalLinksForm.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ export const ExternalLinksForm: FC<ExternalLinksFormProps> = ({
104104
onSubmit={handleSubmit(handleFormSubmit)}
105105
>
106106
{externalLinksFields.map((externalLink, idx) => (
107-
<div key={externalLink.orderNum} data-testid={testIds.externalLink}>
107+
<div key={externalLink.id} data-testid={testIds.externalLink}>
108108
<ExternalLinksFormFields
109109
index={idx}
110110
onRemove={onRemoveExternalLink}

ui/src/components/stop-registry/search/by-line/StopsByLineSearchGroupedStopsResults.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { FC } from 'react';
1+
import { FC, Fragment } from 'react';
22
import { useGroupedResultSelection, useStopSearchRouterState } from '../utils';
33
import { ActiveLineHeader } from './ActiveLineHeader';
44
import { LineRoutesListing } from './LineRoutesListing';
@@ -52,7 +52,7 @@ export const StopsByLineSearchGroupedStopsResults: FC<
5252
{lines
5353
.filter((line) => selectedGroups.includes(line.line_id))
5454
.map((line, i) => (
55-
<>
55+
<Fragment key={line.line_id}>
5656
<ActiveLineHeader
5757
line={line}
5858
className={i > 0 ? 'mt-6' : ''}
@@ -65,7 +65,7 @@ export const StopsByLineSearchGroupedStopsResults: FC<
6565
sortingInfo={sortingInfo}
6666
selection={resultSelection}
6767
/>
68-
</>
68+
</Fragment>
6969
))}
7070
</>
7171
);

0 commit comments

Comments
 (0)