Mark trunk line route stops as trunk line stops on Line Details page#1427
Merged
Huulivoide merged 5 commits intoMay 25, 2026
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Huulivoide
force-pushed
the
mark-trunk-line-route-stops-as-trunk-line-stops
branch
4 times, most recently
from
0498b0a to
e2a6674
Compare
suvikankare
requested changes
May 22, 2026
suvikankare
left a comment
suvikankare
left a comment
Member
There was a problem hiding this comment.
@suvikankare reviewed 14 files and all commit messages, and made 1 comment.
Reviewable status: 14 of 28 files reviewed, 1 unresolved discussion (waiting on Huulivoide).
cypress/e2e/editRoute.cy.ts line 351 at r1 (raw file):
}); describe.only('Trunk Line bus Route', () => {
only
Huulivoide
force-pushed
the
mark-trunk-line-route-stops-as-trunk-line-stops
branch
from
e2a6674 to
a4973de
Compare
suvikankare
approved these changes
May 25, 2026
suvikankare
left a comment
suvikankare
left a comment
Member
There was a problem hiding this comment.
commitit ja lintterit vielä järjestykseen ja sit 
@suvikankare reviewed 15 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:
Implements the basic helpers needed to mark Stops in StopRegistry as Trunk Line stops, when changing a line type to Trunk Line type, or when adding a new stop onto a route on the Line Details page. Due to reasons, this commit also adds basic bits needed to mark a stop as a Speed Tram stop. Overall this is not a pretty clean commit.
Huulivoide
force-pushed
the
mark-trunk-line-route-stops-as-trunk-line-stops
branch
from
63d1f36 to
c9a7c52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add local Hasura endpoint to Graphql.config.yml
Line page: Mark route stops as TrunkLine stops on save
Implements the basic helpers needed to mark Stops in StopRegistry as Trunk Line stops, when changing a line type to Trunk Line type, or when adding a new stop onto a route on the Line Details page.
Due to reasons, this commit also adds basic bits needed to mark a stop as a Speed Tram stop.
Overall this is not a pretty clean commit.
StopDetails: List Trunk Stop status on Basic Details
Route stop: Use
<Link>instead of raw<a>tagE2E: Should mark stops as TrunkLine on Line details page
This change is